Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[#249] Fix of port number leak in NodeBackup::spawn_replica#250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

dmitry-lipetsk
Copy link
Collaborator

@dmitry-lipetskdmitry-lipetsk commentedMay 4, 2025
edited
Loading

This patch has the following changes:

  1. It adds a new argument release_resources to PostgresNode::cleanup method. Default value is False.

  2. It fixes a port number leak in NodeBackup::spawn_replica through explicit call of PostgresNode::cleanup(release_resources=True).

Closes#249.

We must release a port number after the shutdown and cleanup operation not before.It is a part of work forpostgrespro#249
This private method releases all the allocated node resources (port and so on).PostgresNode::__exit__ calls this new method instead free_port.
…is addedWhen this argument is True, cleanup calls _release_resources method.Default value is False.
…ed port number during failureNodeBackup::spawn_replica uses an explict "rollback" code to destroy a newly allocated node to release a reserved port number.
@dmitry-lipetskdmitry-lipetsk merged commitc3b25b2 intopostgrespro:masterMay 4, 2025
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NodeBackup::spawn_replica does not release a reserved port number during failure
1 participant
@dmitry-lipetsk

[8]ページ先頭

©2009-2025 Movatter.jp