- Notifications
You must be signed in to change notification settings - Fork35
PortManager#234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
dmitry-lipetsk merged 32 commits intopostgrespro:masterfromdmitry-lipetsk:D20250403_001--port_managerApr 6, 2025
Merged
PortManager#234
dmitry-lipetsk merged 32 commits intopostgrespro:masterfromdmitry-lipetsk:D20250403_001--port_managerApr 6, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
PostgresNode uses PostgresNodePortManager to reserve/release port numberNew PostgresNode RO-properties are added: - name - host - port - ssh_key
…nager__Global)It is a singleton.
- [del] TestTestgresLocal.test_pgbench- [del] TestTestgresRemote.test_pgbench
- test_port_rereserve_during_node_start- test_port_conflict
…sg_arg]- RemoteOperations::message- RemoteOperations::path_exists- RemoteOperations::is_port_free
Let's install it (netcat-traditional) explicitly.
A number of attempts is increased to 128.The previous value (10) is not enough and test could fail.
- [del] assert hasattr(os_ops, "host")During this test we get another exception:<[AttributeError("'PostgresNode' object has no attribute '_port'") raised in repr()] PostgresNode object at 0x782b67d79dc0>Tests are added: - test_try_to_get_port_after_free_manual_port - test_try_to_start_node_after_free_manual_port
14bc733 intopostgrespro:master 1 check passed
Uh oh!
There was an error while loading.Please reload this page.
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull requestApr 22, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull requestApr 22, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull requestApr 22, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull requestApr 22, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234
fabriziomello added a commit to timescale/timescaledb that referenced this pull requestApr 23, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234
timescale-automation pushed a commit to timescale/timescaledb that referenced this pull requestApr 23, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234(cherry picked from commit3e61107)
timescale-automation pushed a commit to timescale/timescaledb that referenced this pull requestApr 23, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234(cherry picked from commit3e61107)
kpan2034 pushed a commit to kpan2034/timescaledb that referenced this pull requestApr 28, 2025
A new testgres framework was released that makes `PostgresNode::port`read-only. Fixed it by properly set the port when initializing a newnode.References:https://github.com/postgrespro/testgres/releases/tag/1.11.0postgrespro/testgres#234
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Main
Refactoring