Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

OsOps::read methods were corrected (text mode)#171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

dmitry-lipetsk
Copy link
Collaborator

LocalOperations::read and RemoteOperations::read (text mode) are corrected.

  • LocalOperations::read uses "open(filename, mode='r', encoding=encoding)"
  • RemoteOperations::read uses io.BytesIO + io.TextIOWrapper

This patch is tested on Windows 11 (Python 3.13) and Ubuntu 24.04 (Python 3.12).

Internal tests for probackup v2 were passed, too.

Now they always read a file as binary.When 'binary' parameter is False we will use 'encoding' parameter to decode bytes into string.Binary read does not allow an usage of 'encoding' parameter (InvalidOperationException is raised).New tests are added.
LocalOps uses "open(filename, mode='r', encoding=encoding)"RemoteOps uses "io.TextIOWrapper(io.BytesIO(binaryData), encoding=encoding)"It solves a problem on Windows.
@dmitry-lipetskdmitry-lipetsk merged commit155f6c8 intopostgrespro:masterDec 25, 2024
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@demonolockdemonolockAwaiting requested review from demonolock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@dmitry-lipetsk

[8]ページ先頭

©2009-2025 Movatter.jp