NotificationsYou must be signed in to change notification settings
Fork35
Star144

NodeApp::make_simple is refactored (tempfile.gettempdir)#157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dmitry-lipetsk merged 3 commits intopostgrespro:masterfromdmitry-lipetsk:D20241206_001--make_simple

Dec 6, 2024

Merged

NodeApp::make_simple is refactored (tempfile.gettempdir)#157

dmitry-lipetsk merged 3 commits intopostgrespro:masterfromdmitry-lipetsk:D20241206_001--make_simple

Dec 6, 2024

Conversation

Copy link

Collaborator

dmitry-lipetsk commentedDec 6, 2024•
edited
Loading

[BUG FIX] Windows does not have "/tmp" directory. Let's use tempfile.gettempdir() to detect temp directory correctly.
Aggregation of standard and custom options to avoid two calls of node.set_auto_conf

NodeApp::make_simple is refactored (tempfile.gettempdir)

6acbeb6

- [BUG FIX] Windows does not have "/tmp" directory. Let's use tempfile.gettempdir()- Aggregation of standard and custom options to avoid two calls of node.set_auto_conf

dmitry-lipetsk requested a review fromdemonolock

December 6, 2024 10:40