Apr 10, 2024 · Apr 4, 2024 · Apr 8, 2024 · Apr 9, 2024 · Apr 9, 2024 · Apr 10, 2024
diff --git a/testgres/plugins/pg_probackup2/pg_probackup2/init_helpers.py b/testgres/plugins/pg_probackup2/pg_probackup2/init_helpers.py
        os.environ["PGAPPNAME"] = "pg_probackup"
        self.delete_logs = delete_logs

        self.major_version = 0
        if self.probackup_version.split('.')[0].isdigit:
            self.major_version = int(self.probackup_version.split('.')[0])
        else:
            print('Pg_probackup version is not correct!')
            sys.exit(1)

    def test_env(self):
        return self._test_env.copy()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -204,9 +204,11 @@ def __init__(self):
		os.environ["PGAPPNAME"] = "pg_probackup"
		self.delete_logs = delete_logs

		self.major_version = 0
		if self.probackup_version.split('.')[0].isdigit:
Copy link Contributor asavchkovApr 10, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Не .isdigit, а .isdigit(). .isdigit возвращает указатель на метод, который существует у любой строки, поэтому вернёт истинное значение для любой строки: `>>> if 'abc'.isdigit:... print('aaa')... aaa` Copy link CollaboratorAuthor egarbuzApr 10, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Поправил, спасибо.
		self.major_version = int(self.probackup_version.split('.')[0])
		else:
		print('Pg_probackup version is not correct!')
		sys.exit(1)

Copy link Contributor demonolockApr 5, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Можно более безопасные преобразования сделат, на случай если в версии что-то не то будет.Либо не скастится в int либо не будет первого элемента
		def test_env(self):
		return self._test_env.copy()
Expand Down