Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

NodeApp.make_empty must pass os_ops and port_manager to nodes #265

Closed
@dmitry-lipetsk

Description

@dmitry-lipetsk

Constructor of NodeApp obtains os_ops but does not pass it to a new node. See this code:

testgres/testgres/node.py

Lines 2335 to 2346 in44d61c2

self.os_ops=os_ops
defmake_empty(
self,
base_dir=None,
port=None,
bin_dir=None):
real_base_dir=os.path.join(self.test_path,base_dir)
self.os_ops.rmdirs(real_base_dir,ignore_errors=True)
self.os_ops.makedirs(real_base_dir)
node=PostgresNode(base_dir=real_base_dir,port=port,bin_dir=bin_dir)

Also, the constructor of NodeApp can get port_manager object and pass it to the new nodes in make_empty, too.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp