Commitd6be913

authored

[#274] Unused should_rm_dirs is deleted (cleanup) (#275)

This strange PostgresNode property is not documented and is not used in Testgres code.

1 parent8edea09 commitd6be913Copy full SHA for d6be913

File tree

-5

lines changed

-5

lines changed

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -163,10 +163,6 @@ def spawn_primary(self, name=None, destroy=True):`
`163`	`163`	`asserttype(node)==self.original_node.__class__# noqa: E721`
`164`	`164`
`165`	`165`	`withclean_on_error(node)asnode:`
`166`		`-`
`167`		`-# New nodes should always remove dir tree`
`168`		`-node._should_rm_dirs=True`
`169`		`-`
`170`	`166`	`# Set a new port`
`171`	`167`	`node.append_conf(filename=PG_CONF_FILE,line='\n')`
`172`	`168`	`node.append_conf(filename=PG_CONF_FILE,port=node.port)`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2384,7 +2384,6 @@ def make_empty(`
`2384`	`2384`	`self.os_ops.makedirs(real_base_dir)`
`2385`	`2385`
`2386`	`2386`	`node=PostgresNode(base_dir=real_base_dir,port=port,bin_dir=bin_dir)`
`2387`		`-node.should_rm_dirs=True`
`2388`	`2387`	`self.nodes_to_cleanup.append(node)`
`2389`	`2388`
`2390`	`2389`	`returnnode`

Comments

(0)