Commitbc6c302

committed

Fix: primary_slot_name never actually was set

1 parent3e5dbec commitbc6c302Copy full SHA for bc6c302

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ def spawn_replica(self, name=None, destroy=True, slot_name=None):`
`171`	`171`
`172`	`172`	`# Assign it a master and a recovery file (private magic)`
`173`	`173`	`node._assign_master(self.original_node)`
`174`		`-node._create_recovery_conf(username=self.username)`
	`174`	`+node._create_recovery_conf(username=self.username,slot_name=slot_name)`
`175`	`175`
`176`	`176`	`returnnode`
`177`	`177`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ def _create_recovery_conf(self, username, slot_name=None):`
`209`	`209`	`).format(conninfo)`
`210`	`210`
`211`	`211`	`ifslot_name:`
`212`		`-line+="primary_slot_name={}\n".format()`
	`212`	`+line+="primary_slot_name={}\n".format(slot_name)`
`213`	`213`
`214`	`214`	`self.append_conf(RECOVERY_CONF_FILE,line)`
`215`	`215`
`@@ -872,7 +872,9 @@ def create_replication_slot(self, slot_name, dbname=None, username=None):`
`872`	`872`	`dbname: database name`
`873`	`873`	`username: database user name`
`874`	`874`	`"""`
`875`		`-query="select pg_create_physical_replication_slot('{}')".format(slot_name)`
	`875`	`+query= (`
	`876`	`+"select pg_create_physical_replication_slot('{}')"`
	`877`	`+ ).format(slot_name)`
`876`	`878`
`877`	`879`	`self.execute(query=query,`
`878`	`880`	`dbname=dbnameordefault_dbname(),`

Comments

(0)