Commit901f0ec

committed

don't remove base_dir if it was provided by user

1 parentc0bcc7b commit901f0ecCopy full SHA for 901f0ec

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -417,6 +417,7 @@ def __init__(self,`
`417`	`417`	`self.port=portorreserve_port()`
`418`	`418`	`self.should_free_port=portisNone`
`419`	`419`	`self.base_dir=base_dirortempfile.mkdtemp()`
	`420`	`+self.should_rm_base_dir=base_dirisNone`
`420`	`421`	`self.use_logging=use_logging`
`421`	`422`	`self.logger=None`
`422`	`423`
`@@ -749,8 +750,9 @@ def cleanup(self, max_attempts=3):`
`749`	`750`
`750`	`751`	`attempts+=1`
`751`	`752`
`752`		`-# remove data directory`
`753`		`-shutil.rmtree(self.data_dir,ignore_errors=True)`
	`753`	`+# remove data directory if necessary`
	`754`	`+ifself.should_rm_base_dir:`
	`755`	`+shutil.rmtree(self.data_dir,ignore_errors=True)`
`754`	`756`
`755`	`757`	`returnself`
`756`	`758`

Comments

(0)