Commit7fd2f07

authored

RemoteOperations::exec_command updated (#185)

- Exact enumeration of supported 'cmd' types- Refactoring

1 parent22c4763 commit7fd2f07Copy full SHA for 7fd2f07

File tree

-5

lines changed

-5

lines changed

Lines changed: 8 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -78,14 +78,17 @@ def exec_command(self, cmd, wait_exit=False, verbose=False, expect_error=False,`
`78`	`78`
`79`	`79`	`assertinput_preparedisNoneor (type(input_prepared)==bytes)# noqa: E721`
`80`	`80`
`81`		`-ssh_cmd= []`
`82`		`-ifisinstance(cmd,str):`
`83`		`-ssh_cmd= ['ssh',self.ssh_dest]+self.ssh_args+ [cmd]`
`84`		`-elifisinstance(cmd,list):`
`85`		`-ssh_cmd= ['ssh',self.ssh_dest]+self.ssh_args+ [subprocess.list2cmdline(cmd)]`
	`81`	`+iftype(cmd)==str:# noqa: E721`
	`82`	`+cmd_s=cmd`
	`83`	`+eliftype(cmd)==list:# noqa: E721`
	`84`	`+cmd_s=subprocess.list2cmdline(cmd)`
`86`	`85`	`else:`
`87`	`86`	`raiseValueError("Invalid 'cmd' argument type - {0}".format(type(cmd).__name__))`
`88`	`87`
	`88`	`+asserttype(cmd_s)==str# noqa: E721`
	`89`	`+`
	`90`	`+ssh_cmd= ['ssh',self.ssh_dest]+self.ssh_args+ [cmd_s]`
	`91`	`+`
`89`	`92`	`process=subprocess.Popen(ssh_cmd,stdin=subprocess.PIPE,stdout=subprocess.PIPE,stderr=subprocess.PIPE)`
`90`	`93`	`assertnot (processisNone)`
`91`	`94`	`ifget_process:`

Comments

(0)