NotificationsYou must be signed in to change notification settings
Fork35
Star144

Commit7c0f184

committed

RemoteOperations is updated (read_binary, get_file_size)

get_file_size and get_file_size use a list for command list arguments.It allows to use standard way to escape a filename.Our bicycle "_escape_path" is deleted.

1 parent44c5fac commit7c0f184Copy full SHA for 7c0f184

File tree

1 file changed

-11

lines changed

testgres/operations
- remote_ops.py

1 file changed

-11

lines changed

`‎testgres/operations/remote_ops.py`

Lines changed: 2 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ def read_binary(self, filename, start_pos):`
`347`	`347`	`asserttype(start_pos)==int# noqa: E721`
`348`	`348`	`assertstart_pos>=0`
`349`	`349`
`350`		`-cmd="tail -c+{} {}".format(start_pos+1,__class__._escape_path(filename))`
	`350`	`+cmd=["tail","-c","+{}".format(start_pos+1),filename]`
`351`	`351`	`r=self.exec_command(cmd)`
`352`	`352`	`asserttype(r)==bytes# noqa: E721`
`353`	`353`	`returnr`
`@@ -367,7 +367,7 @@ def get_file_size(self, filename):`
`367`	`367`
`368`	`368`	`assertfilenameisnotNone`
`369`	`369`	`asserttype(filename)==str# noqa: E721`
`370`		`-cmd="du -b "+__class__._escape_path(filename)`
	`370`	`+cmd=["du","-b",filename]`
`371`	`371`
`372`	`372`	`s=self.exec_command(cmd,encoding=get_default_encoding())`
`373`	`373`	`asserttype(s)==str# noqa: E721`
`@@ -462,15 +462,6 @@ def db_connect(self, dbname, user, password=None, host="localhost", port=5432):`
`462`	`462`	`)`
`463`	`463`	`returnconn`
`464`	`464`
`465`		`-def_escape_path(path):`
`466`		`-asserttype(path)==str# noqa: E721`
`467`		`-assertpath!=""# Ok?`
`468`		`-`
`469`		`-r="'"`
`470`		`-r+=path`
`471`		`-r+="'"`
`472`		`-returnr`
`473`		`-`
`474`	`465`
`475`	`466`	`defnormalize_error(error):`
`476`	`467`	`ifisinstance(error,bytes):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7c0f184

File tree

1 file changed

1 file changed

`‎testgres/operations/remote_ops.py`

0 commit comments