Commit59dbe42

committed

When creating new physical replication slot check that it doesn't already exist

1 parente2e5a8d commit59dbe42Copy full SHA for 59dbe42

File tree

+15

-2

lines changed

+15

-2

lines changed

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,8 @@`
`49`	`49`	`ExecUtilException, \`
`50`	`50`	`QueryException, \`
`51`	`51`	`StartNodeException, \`
`52`		`-TimeoutException`
	`52`	`+TimeoutException, \`
	`53`	`+TestgresException`
`53`	`54`
`54`	`55`	`from .loggerimportTestgresLogger`
`55`	`56`
`@@ -263,6 +264,13 @@ def _create_replication_slot(self, slot_name, dbname=None, username=None):`
`263`	`264`	`dbname: database name`
`264`	`265`	`username: database user name`
`265`	`266`	`"""`
	`267`	`+rs=self.execute("select exists (select * from pg_replication_slots "`
	`268`	`+"where slot_name = '{}')".format(slot_name),`
	`269`	`+dbname=dbname,username=username)`
	`270`	`+`
	`271`	`+ifrs[0][0]:`
	`272`	`+raiseTestgresException("Slot '{}' already exists".format(slot_name))`
	`273`	`+`
`266`	`274`	`query= (`
`267`	`275`	`"select pg_create_physical_replication_slot('{}')"`
`268`	`276`	`).format(slot_name)`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,8 @@`
`21`	`21`	`BackupException, \`
`22`	`22`	`QueryException, \`
`23`	`23`	`CatchUpException, \`
`24`		`-TimeoutException`
	`24`	`+TimeoutException, \`
	`25`	`+TestgresException`
`25`	`26`
`26`	`27`	`fromtestgresimport \`
`27`	`28`	`TestgresConfig, \`
`@@ -393,6 +394,10 @@ def test_replication_slots(self):`
`393`	`394`	`res=replica.execute('select * from test')`
`394`	`395`	`self.assertListEqual(res, [(1, ), (2, )])`
`395`	`396`
	`397`	`+# cannot create new slot with the same name`
	`398`	`+withself.assertRaises(TestgresException):`
	`399`	`+node._create_replication_slot('slot1')`
	`400`	`+`
`396`	`401`	`deftest_incorrect_catchup(self):`
`397`	`402`	`withget_new_node()asnode:`
`398`	`403`	`node.init(allow_streaming=True).start()`

Comments

(0)