NotificationsYou must be signed in to change notification settings
Fork37
Star150

Commit4afbe00

committed

Using pytest [assertIn]

1 parenteaaa276 commit4afbe00Copy full SHA for 4afbe00

File tree

2 files changed

-14

lines changed

tests
- test_simple.py
- test_simple_remote.py

2 files changed

-14

lines changed

`‎tests/test_simple.py‎`

Lines changed: 5 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -321,8 +321,8 @@ def test_safe_psql__expect_error(self):`
`321`	`321`	`withget_new_node().init().start()asnode:`
`322`	`322`	`err=node.safe_psql('select_or_not_select 1',expect_error=True)`
`323`	`323`	`assert (type(err)==str)# noqa: E721`
`324`		`-self.assertIn('select_or_not_select',err)`
`325`		`-self.assertIn('ERROR: syntax error at or near "select_or_not_select"',err)`
	`324`	`+assert('select_or_not_select'inerr)`
	`325`	`+assert('ERROR: syntax error at or near "select_or_not_select"'inerr)`
`326`	`326`
`327`	`327`	`# ---------`
`328`	`328`	`withpytest.raises(`
`@@ -1011,11 +1011,11 @@ def test_child_pids(self):`
`1011`	`1011`
`1012`	`1012`	`master_pids=master.auxiliary_pids`
`1013`	`1013`	`forptypeinmaster_processes:`
`1014`		`-self.assertIn(ptype,master_pids)`
	`1014`	`+assert(ptypeinmaster_pids)`
`1015`	`1015`
`1016`	`1016`	`replica_pids=replica.auxiliary_pids`
`1017`	`1017`	`forptypeinrepl_processes:`
`1018`		`-self.assertIn(ptype,replica_pids)`
	`1018`	`+assert(ptypeinreplica_pids)`
`1019`	`1019`
`1020`	`1020`	`# there should be exactly 1 source walsender for replica`
`1021`	`1021`	`assert (len(master_pids[ProcessType.WalSender])==1)`
`@@ -1320,12 +1320,7 @@ def test_set_auto_conf(self):`
`1320`	`1320`	`content=f.read()`
`1321`	`1321`
`1322`	`1322`	`forxintestData:`
`1323`		`-self.assertIn(`
`1324`		`-x[0]+" = "+x[2],`
`1325`		`-content,`
`1326`		`-x[0]+" stored wrong"`
`1327`		`- )`
`1328`		`-`
	`1323`	`+assertx[0]+" = "+x[2]incontent`
`1329`	`1324`	`@staticmethod`
`1330`	`1325`	`defhelper__skip_test_if_util_not_exist(name:str):`
`1331`	`1326`	`asserttype(name)==str# noqa: E721`

`‎tests/test_simple_remote.py‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -377,8 +377,8 @@ def test_safe_psql__expect_error(self):`
`377`	`377`	`withget_remote_node(conn_params=conn_params).init().start()asnode:`
`378`	`378`	`err=node.safe_psql('select_or_not_select 1',expect_error=True)`
`379`	`379`	`assert (type(err)==str)# noqa: E721`
`380`		`-self.assertIn('select_or_not_select',err)`
`381`		`-self.assertIn('ERROR: syntax error at or near "select_or_not_select"',err)`
	`380`	`+assert('select_or_not_select'inerr)`
	`381`	`+assert('ERROR: syntax error at or near "select_or_not_select"'inerr)`
`382`	`382`
`383`	`383`	`# ---------`
`384`	`384`	`withpytest.raises(`
`@@ -1054,11 +1054,11 @@ def test_child_pids(self):`
`1054`	`1054`
`1055`	`1055`	`master_pids=master.auxiliary_pids`
`1056`	`1056`	`forptypeinmaster_processes:`
`1057`		`-self.assertIn(ptype,master_pids)`
	`1057`	`+assert(ptypeinmaster_pids)`
`1058`	`1058`
`1059`	`1059`	`replica_pids=replica.auxiliary_pids`
`1060`	`1060`	`forptypeinrepl_processes:`
`1061`		`-self.assertIn(ptype,replica_pids)`
	`1061`	`+assert(ptypeinreplica_pids)`
`1062`	`1062`
`1063`	`1063`	`# there should be exactly 1 source walsender for replica`
`1064`	`1064`	`assert (len(master_pids[ProcessType.WalSender])==1)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4afbe00

File tree

2 files changed

2 files changed

`‎tests/test_simple.py‎`

`‎tests/test_simple_remote.py‎`

0 commit comments