NotificationsYou must be signed in to change notification settings
Fork35
Star144

Commit3006ecf

committed

small refactoring for NodeBackup

1 parentc055739 commit3006ecfCopy full SHA for 3006ecf

File tree

1 file changed

+24

-7

lines changed

testgres
- testgres.py

1 file changed

+24

-7

lines changed

`‎testgres/testgres.py`

Lines changed: 24 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -294,16 +294,15 @@ def __enter__(self):`
`294`	`294`	`def__exit__(self,type,value,traceback):`
`295`	`295`	`self.cleanup()`
`296`	`296`
`297`		`-defspawn_primary(self,name,destroy=True):`
	`297`	`+def_prepare_dir(self,destroy):`
`298`	`298`	`"""`
`299`		`-Create aprimary node from abackup.`
	`299`	`+Provide adata directory for acopy of node.`
`300`	`300`
`301`	`301`	`Args:`
`302`		`- name: name for a new node (str).`
`303`	`302`	`destroy: should we convert this backup into a node?`
`304`	`303`
`305`	`304`	`Returns:`
`306`		`-New instance of PostgresNode.`
	`305`	`+Path to data directory.`
`307`	`306`	`"""`
`308`	`307`
`309`	`308`	`ifnotself.available:`
`@@ -326,14 +325,32 @@ def spawn_primary(self, name, destroy=True):`
`326`	`325`	`else:`
`327`	`326`	`base_dir=self.base_dir`
`328`	`327`
	`328`	`+# update value`
	`329`	`+self.available=available`
	`330`	`+`
	`331`	`+returnbase_dir`
	`332`	`+`
	`333`	`+defspawn_primary(self,name,destroy=True):`
	`334`	`+"""`
	`335`	`+ Create a primary node from a backup.`
	`336`	`+`
	`337`	`+ Args:`
	`338`	`+ name: name for a new node (str).`
	`339`	`+ destroy: should we convert this backup into a node?`
	`340`	`+`
	`341`	`+ Returns:`
	`342`	`+ New instance of PostgresNode.`
	`343`	`+ """`
	`344`	`+`
	`345`	`+base_dir=self._prepare_dir(destroy)`
	`346`	`+`
`329`	`347`	`# build a new PostgresNode`
`330`	`348`	`node=PostgresNode(name=name,`
`331`	`349`	`base_dir=base_dir,`
`332`	`350`	`master=self.original_node)`
`333`		`-node.append_conf("postgresql.conf","port = {}".format(node.port))`
`334`	`351`
`335`		`-# record new status`
`336`		`-self.available=available`
	`352`	`+node.append_conf("postgresql.conf","\n")`
	`353`	`+node.append_conf("postgresql.conf","port = {}".format(node.port))`
`337`	`354`
`338`	`355`	`returnnode`
`339`	`356`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3006ecf

File tree

1 file changed

1 file changed

`‎testgres/testgres.py`

0 commit comments