Commit230e562

authored

RemoteOperations::listdir is corrected (#217)

- It returns list[str]- New asserts are addedTests for listdir are updated.

1 parente3eb6ae commit230e562Copy full SHA for 230e562

File tree

+20

-3

lines changed

+20

-3

lines changed

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -277,8 +277,12 @@ def listdir(self, path):`
`277`	`277`	`Args:`
`278`	`278`	`path (str): The path to the directory.`
`279`	`279`	`"""`
`280`		`-result=self.exec_command("ls {}".format(path))`
`281`		`-returnresult.splitlines()`
	`280`	`+command= ["ls",path]`
	`281`	`+output=self.exec_command(cmd=command,encoding=get_default_encoding())`
	`282`	`+asserttype(output)==str# noqa: E721`
	`283`	`+result=output.splitlines()`
	`284`	`+asserttype(result)==list# noqa: E721`
	`285`	`+returnresult`
`282`	`286`
`283`	`287`	`defpath_exists(self,path):`
`284`	`288`	`command= ["test","-e",path]`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,17 @@ def test_exec_command_failure__expect_error(self):`
`87`	`87`	`assertb"nonexistent_command"inerror`
`88`	`88`	`assertb"not found"inerror`
`89`	`89`
	`90`	`+deftest_listdir(self):`
	`91`	`+"""`
	`92`	`+ Test listdir for listing directory contents.`
	`93`	`+ """`
	`94`	`+path="/etc"`
	`95`	`+files=self.operations.listdir(path)`
	`96`	`+assertisinstance(files,list)`
	`97`	`+forfinfiles:`
	`98`	`+assertfisnotNone`
	`99`	`+asserttype(f)==str# noqa: E721`
	`100`	`+`
`90`	`101`	`deftest_read__text(self):`
`91`	`102`	`"""`
`92`	`103`	`Test LocalOperations::read for text data.`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -222,8 +222,10 @@ def test_listdir(self):`
`222`	`222`	`"""`
`223`	`223`	`path="/etc"`
`224`	`224`	`files=self.operations.listdir(path)`
`225`		`-`
`226`	`225`	`assertisinstance(files,list)`
	`226`	`+forfinfiles:`
	`227`	`+assertfisnotNone`
	`228`	`+asserttype(f)==str# noqa: E721`
`227`	`229`
`228`	`230`	`deftest_path_exists_true__directory(self):`
`229`	`231`	`"""`

Comments

(0)