Commit02f7f00

committed

[#249] NodeBackup::spawn_replica does not release a reserved port number during failure

NodeBackup::spawn_replica uses an explict "rollback" code to destroy a newly allocated node to release a reserved port number.

1 parent102289b commit02f7f00Copy full SHA for 02f7f00

File tree

-3

lines changed

-3

lines changed

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -184,14 +184,19 @@ def spawn_replica(self, name=None, destroy=True, slot=None):`
`184`	`184`	`"""`
`185`	`185`
`186`	`186`	`# Build a new PostgresNode`
`187`		`-withclean_on_error(self.spawn_primary(name=name,`
`188`		`-destroy=destroy))asnode:`
	`187`	`+node=self.spawn_primary(name=name,destroy=destroy)`
	`188`	`+assertnodeisnotNone`
`189`	`189`
	`190`	`+try:`
`190`	`191`	`# Assign it a master and a recovery file (private magic)`
`191`	`192`	`node._assign_master(self.original_node)`
`192`	`193`	`node._create_recovery_conf(username=self.username,slot=slot)`
	`194`	`+except:# noqa: E722`
	`195`	`+# TODO: Pass 'final=True' ?`
	`196`	`+node.cleanup(release_resources=True)`
	`197`	`+raise`
`193`	`198`
`194`		`-returnnode`
	`199`	`+returnnode`
`195`	`200`
`196`	`201`	`defcleanup(self):`
`197`	`202`	`"""`

Comments

(0)