Commit008236d

committed

Added test for PostgresNode.__repr__() method; removed node name from examples

1 parent57eaea1 commit008236dCopy full SHA for 008236d

File tree

+13

-7

lines changed

+13

-7

lines changed

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,27 +7,27 @@`
`7`	`7`	`edit configuration files, start/stop cluster, execute queries. The`
`8`	`8`	`typical flow may look like:`
`9`	`9`
`10`		`->>> with get_new_node('test') as node:`
	`10`	`+>>> with get_new_node() as node:`
`11`	`11`	`... node.init().start()`
`12`	`12`	`... result = node.safe_psql('postgres', 'select 1')`
`13`	`13`	`... print(result.decode('utf-8').strip())`
`14`	`14`	`... node.stop()`
`15`		`-PostgresNode('test', port=..., base_dir=...)`
	`15`	`+PostgresNode(name='...', port=..., base_dir='...')`
`16`	`16`	`1`
`17`		`-PostgresNode('test', port=..., base_dir=...)`
	`17`	`+PostgresNode(name='...', port=..., base_dir='...')`
`18`	`18`
`19`	`19`	`Or:`
`20`	`20`
`21`		`->>> with get_new_node('master') as master:`
	`21`	`+>>> with get_new_node() as master:`
`22`	`22`	`... master.init().start()`
`23`	`23`	`... with master.backup() as backup:`
`24`		`-... with backup.spawn_replica('replica') as replica:`
	`24`	`+... with backup.spawn_replica() as replica:`
`25`	`25`	`... replica = replica.start()`
`26`	`26`	`... master.execute('postgres', 'create table test (val int4)')`
`27`	`27`	`... master.execute('postgres', 'insert into test values (0), (1), (2)')`
`28`	`28`	`... replica.catchup() # wait until changes are visible`
`29`	`29`	`... print(replica.execute('postgres', 'select count(*) from test'))`
`30`		`-PostgresNode('master', port=..., base_dir=...)`
	`30`	`+PostgresNode(name='...', port=..., base_dir='...')`
`31`	`31`	`[(3,)]`
`32`	`32`
`33`	`33`	`Copyright (c) 2016, Postgres Professional`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ def __exit__(self, type, value, traceback):`
`136`	`136`	`self._try_shutdown(attempts)`
`137`	`137`
`138`	`138`	`def__repr__(self):`
`139`		`-return"PostgresNode('{}', port={}, base_dir={})".format(`
	`139`	`+return"PostgresNode(name='{}', port={}, base_dir='{}')".format(`
`140`	`140`	`self.name,self.port,self.base_dir)`
`141`	`141`
`142`	`142`	`@property`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`# coding: utf-8`
`3`	`3`
`4`	`4`	`importos`
	`5`	`+importre`
`5`	`6`	`importsubprocess`
`6`	`7`	`importtempfile`
`7`	`8`	`importtestgres`
`@@ -70,6 +71,11 @@ def removing(f):`
`70`	`71`
`71`	`72`
`72`	`73`	`classTestgresTests(unittest.TestCase):`
	`74`	`+deftest_node_repr(self):`
	`75`	`+withget_new_node()asnode:`
	`76`	`+pattern='PostgresNode\(name=\'.+\', port=.+, base_dir=\'.+\'\)'`
	`77`	`+self.assertIsNotNone(re.match(pattern,str(node)))`
	`78`	`+`
`73`	`79`	`deftest_custom_init(self):`
`74`	`80`	`withget_new_node()asnode:`
`75`	`81`	`# enable page checksums`

Comments

(0)