Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Predicate locking in rum index#24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
za-arthur merged 3 commits intopostgrespro:masterfromshubhambaraiss:predicate_rum
Aug 21, 2017

Conversation

shubhambaraiss
Copy link

No description provided.

Copy link
Contributor

@za-arthurza-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I left comments toMakefile changes.
There is a problem with test pglist_tests.py. It fails. PostgreSQL's logs is:

2017-08-16 11:00:44.284 GMT [13368] LOG:  listening on IPv4 address "127.0.0.1", port 163172017-08-16 11:00:44.284 GMT [13368] LOG:  listening on Unix socket "/tmp/.s.PGSQL.16317"2017-08-16 11:00:44.349 GMT [13369] LOG:  database system was shut down at 2017-08-16 11:00:44 GMT2017-08-16 11:00:44.349 GMT [13368] LOG:  database system is ready to accept connections2017-08-16 11:00:44.390 GMT [13376] LOG:  execute pg8000_statement_0/pg8000_portal_0: begin transaction2017-08-16 11:00:44.392 GMT [13376] LOG:  execute pg8000_statement_1/pg8000_portal_1: SELECT count(*) FROM pg_database WHERE datistemplate = false AND   datname = 'pglist'2017-08-16 11:00:44.406 GMT [13378] LOG:  statement: CREATE DATABASE pglist2017-08-16 11:00:44.633 GMT [13380] LOG:  statement: SET statement_timeout = 0;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET lock_timeout = 0;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET client_encoding = 'UTF8';2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET standard_conforming_strings = on;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET check_function_bodies = false;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET client_min_messages = warning;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET row_security = off;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET search_path = public, pg_catalog;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET default_tablespace = '';2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: SET default_with_oids = false;2017-08-16 11:00:44.634 GMT [13380] LOG:  statement: CREATE TABLE pglist (    id integer,    sent timestamp without time zone,    subject text,    author text,    body_plain text,    fts tsvector);2017-08-16 11:00:44.637 GMT [13380] LOG:  statement: ALTER TABLE pglist OWNER TO oleg;2017-08-16 11:00:44.637 GMT [13380] ERROR:  role "oleg" does not exist2017-08-16 11:00:44.637 GMT [13380] STATEMENT:  ALTER TABLE pglist OWNER TO oleg;2017-08-16 11:00:44.637 GMT [13380] LOG:  statement: COPY pglist (id, sent, subject, author, body_plain, fts) FROM stdin;2017-08-16 11:03:12.714 GMT [13628] LOG:  statement: CREATE EXTENSION rum2017-08-16 11:03:12.789 GMT [13630] LOG:  statement: CREATE INDEX rumidx_orderby_sent ON pglist USING rum (  fts rum_tsvector_timestamp_ops, sent)   WITH (attach=sent, to=fts, order_by_attach=t)2017-08-16 11:07:05.088 GMT [13761] LOG:  statement: SELECT sent, subject   FROM pglist   WHERE fts @@     to_tsquery('english', 'backend <-> crushed')   ORDER BY sent <=| '2016-01-01 00:01' LIMIT 5TRAP: FailedAssertion("!(( !( ((void) ((bool) (! (!((buffer) <= NBuffers && (buffer) >= -NLocBuffer)) || (ExceptionalCondition("!((buffer) <= NBuffers && (buffer) >= -NLocBuffer)", ("FailedAssertion"), "bufmgr.c", 2609), 0)))), (buffer) != 0 ) ? ((bool) 0) : ((buffer) < 0) ? (LocalRefCount[-(buffer) - 1] > 0) : (GetPrivateRefCount(buffer) > 0) ))", File: "bufmgr.c", Line: 2609)2017-08-16 11:08:16.486 GMT [13368] LOG:  server process (PID 13761) was terminated by signal 6: Aborted2017-08-16 11:08:16.486 GMT [13368] DETAIL:  Failed process was running: SELECT sent, subject   FROM pglist   WHERE fts @@     to_tsquery('english', 'backend <-> crushed')   ORDER BY sent <=| '2016-01-01 00:01' LIMIT 52017-08-16 11:08:16.486 GMT [13368] LOG:  terminating any other active server processes2017-08-16 11:08:16.487 GMT [13766] WARNING:  terminating connection because of crash of another server process2017-08-16 11:08:16.487 GMT [13766] DETAIL:  The postmaster has commanded this server process to roll back the current transaction and exit, because another server process exited abnormally and possibly corrupted shared memory.2017-08-16 11:08:16.487 GMT [13766] HINT:  In a moment you should be able to reconnect to the database and repeat your command.2017-08-16 11:08:16.490 GMT [13373] WARNING:  terminating connection because of crash of another server process2017-08-16 11:08:16.490 GMT [13373] DETAIL:  The postmaster has commanded this server process to roll back the current transaction and exit, because another server process exited abnormally and possibly corrupted shared memory.2017-08-16 11:08:16.490 GMT [13373] HINT:  In a moment you should be able to reconnect to the database and repeat your command.2017-08-16 11:08:16.502 GMT [13368] LOG:  received fast shutdown request2017-08-16 11:08:16.502 GMT [13368] LOG:  aborting any active transactions2017-08-16 11:08:16.614 GMT [13368] LOG:  abnormal database system shutdown2017-08-16 11:08:16.903 GMT [13368] LOG:  database system is shut down

Makefile Outdated
@@ -35,6 +35,14 @@ endif
wal-check: temp-install
$(prove_check)

check: isolationcheck
Copy link
Contributor

@za-arthurza-arthurAug 16, 2017•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you removecheck target? This target makes it impossible to runcheck withUSE_PGXS variable. With this target you can runcheck only under thecontrib directory.
To run isolationcheck you can execute the command:

make isolationcheck

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

okay, I will make changes.

@shubhambaraiss
Copy link
Author

I have updated makefile like you said.

@za-arthur
Copy link
Contributor

za-arthur commentedAug 17, 2017•
edited
Loading

Thank you for fix makefile. Can you look at the error I commented above? The error is:

TRAP: FailedAssertion("!(( !( ((void) ((bool) (! (!((buffer) <= NBuffers && (buffer) >= -NLocBuffer)) || (ExceptionalCondition("!((buffer) <= NBuffers && (buffer) >= -NLocBuffer)", ("FailedAssertion"), "bufmgr.c", 2609), 0)))), (buffer) != 0 ) ? ((bool) 0) : ((buffer) < 0) ? (LocalRefCount[-(buffer) - 1] > 0) : (GetPrivateRefCount(buffer) > 0) ))", File: "bufmgr.c", Line: 2609)

It appears inFile: "bufmgr.c", Line: 2609

To get assert errors you should build PostgreSQL with--enable-cassert key. And you may want to add--enable-debug key. For example:

=# cd postgres=# ./configure --enable-debug --enable-cassert=# make=# make install

To reproduce the error you can look at testhttps://github.com/postgrespro/rum/blob/master/tests/pglist_tests.py
Additional information you can get fromhttps://www.postgresql.org/docs/9.6/static/install-procedure.html

@za-arthurza-arthur merged commitc5be71b intopostgrespro:masterAug 21, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@za-arthurza-arthurza-arthur requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@shubhambaraiss@za-arthur
[8]ページ先頭
©2009-2025 Movatter.jp