- Notifications
You must be signed in to change notification settings - Fork58
[PGPRO-11599] Fix wrong results returned when order_by_attach=TRUE.#164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
arseny114 wants to merge3 commits intopostgrespro:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+9,928 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Static functions from TIDBitmap were added to RUM as RumTIDBitmap.A function has been added to search for tid inside RumTIDBitmap.Tags: rum
With order_by_attach=TRUE, the RUM index arranges the entries in the postinglists (for keys that have additional information) in order of sorting byadditional information. For the remaining keys, the records are sorted by tid.The scanGetItemRegular() function assumes that all posting lists have the samesorting, so it was not suitable for sorting in this case.In order to fix this, the appropriate TIDs for keys that are ordered by tid areassembled in advance into a bitmap. For keys ordered in an alternative order, aroutine scan is performed, after which the appropriate tid is checked in thebitmap.Tags: rum
8ce7ba5 to5bbd4f8CompareNote:#79 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With order_by_attach=TRUE, the RUM index arranges the entries in the posting lists (for keys that have additional information) in order of sorting by additional information. For the remaining keys, the records are sorted by tid. The scanGetItemRegular() function assumes that all posting lists have the same sorting, so it was not suitable for sorting in this case.
In order to fix this, the appropriate TIDs for keys that are ordered by tid are assembled in advance into a bitmap. For keys ordered in an alternative order, a routine scan is performed, after which the appropriate tid is checked in the bitmap.
Tags: rum