Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix compiler warnings due to new checks in PostgreSQL 16#115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kovdb75 merged 1 commit intostablefromPGPRO-7444
Nov 22, 2022

Conversation

MarinaPolyakova
Copy link
Contributor

See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add -Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.

src/ruminsert.c: In function ‘rumHeapTupleBulkInsert’:src/ruminsert.c:533:51: warning: declaration of ‘attr’ shadows a previous local [-Wshadow=compatible-local]  533 |                                 Form_pg_attribute attr = RumTupleDescAttr(      |                                                   ^~~~src/ruminsert.c:505:27: note: shadowed declaration is here  505 |         Form_pg_attribute attr = buildstate->rumstate.addAttrs[attnum - 1];      |                           ^~~~src/rumget.c: In function ‘startScanEntry’:src/rumget.c:635:41: warning: declaration of ‘page’ shadows a previous local [-Wshadow=compatible-local]  635 |                         Page            page;      |                                         ^~~~src/rumget.c:548:25: note: shadowed declaration is here  548 |         Page            page;      |                         ^~~~src/rumget.c: In function ‘entryGetNextItemList’:src/rumget.c:1054:33: warning: declaration of ‘page’ shadows a previous local [-Wshadow=compatible-local] 1054 |                 Page            page;      |                                 ^~~~src/rumget.c:986:25: note: shadowed declaration is here  986 |         Page            page;      |                         ^~~~

See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add-Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.src/ruminsert.c: In function ‘rumHeapTupleBulkInsert’:src/ruminsert.c:533:51: warning: declaration of ‘attr’ shadows a previous local[-Wshadow=compatible-local]  533 |                                 Form_pg_attribute attr =RumTupleDescAttr(      |                                                   ^~~~src/ruminsert.c:505:27: note: shadowed declaration is here  505 |         Form_pg_attribute attr = buildstate->rumstate.addAttrs[attnum- 1];      |                           ^~~~src/rumget.c: In function ‘startScanEntry’:src/rumget.c:635:41: warning: declaration of ‘page’ shadows a previous local[-Wshadow=compatible-local]  635 |                         Page            page;      |                                         ^~~~src/rumget.c:548:25: note: shadowed declaration is here  548 |         Page            page;      |                         ^~~~src/rumget.c: In function ‘entryGetNextItemList’:src/rumget.c:1054:33: warning: declaration of ‘page’ shadows a previous local[-Wshadow=compatible-local] 1054 |                 Page            page;      |                                 ^~~~src/rumget.c:986:25: note: shadowed declaration is here  986 |         Page            page;      |                         ^~~~
@codecov
Copy link

codecovbot commentedNov 21, 2022•
edited
Loading

Codecov Report

Merging#115 (702d215) intostable (884bd51) willincrease coverage by8.96%.
The diff coverage is100.00%.

❗ Current head702d215 differs from pull request most recent head43465cb. Consider uploading reports for the commit43465cb to get more accurate results

@@            Coverage Diff             @@##           stable     #115      +/-   ##==========================================+ Coverage   44.76%   53.73%   +8.96%==========================================  Files          33       29       -4       Lines       12033     9419    -2614     ==========================================- Hits         5387     5061     -326+ Misses       6646     4358    -2288
Impacted FilesCoverage Δ
src/rumget.c88.05% <ø> (ø)
src/ruminsert.c86.92% <100.00%> (ø)
src/rum_ts_utils.c87.81% <0.00%> (-0.15%)⬇️
src/rumsort.c87.68% <0.00%> (-0.09%)⬇️
src/rumutil.c86.89% <0.00%> (-0.04%)⬇️
pg_bin/include/postgresql/server/postgres.h100.00% <0.00%> (ø)
pg_bin/include/postgresql/server/nodes/pg_list.h100.00% <0.00%> (ø)
pg_bin/include/postgresql/server/access/tableam.h100.00% <0.00%> (ø)
src/tuplesort14.c
pg_bin/include/postgresql/server/common/hashfn.h
... and2 more

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

@kovdb75
Copy link
Contributor

Probably some changes (vanilla changes?) caused the test "test array" to fail (see Travis CI result).
Can we fix this test in current task or we should create a new one?

@kovdb75
Copy link
Contributor

I'll ask developers about travis-ci.

MarinaPolyakova reacted with thumbs up emoji

@kovdb75kovdb75 merged commit7e641a8 intostableNov 22, 2022
@MarinaPolyakova
Copy link
ContributorAuthor

Thank you! I reproduced this problem manually on the previous commit884bd51 with REL_15_BETA1:

diff -U3 /home/marina/rum/expected/array.out /home/marina/rum/results/array.out--- /home/marina/rum/expected/array.out2022-11-21 14:11:54.423452310 +0300+++ /home/marina/rum/results/array.out2022-11-22 13:55:19.820341443 +0300@@ -527,10 +527,10 @@ SELECT * FROM test_array WHERE i && '{1}' ORDER BY add_info <=> '2016-05-16 14:21:25' LIMIT 10;      i     |         add_info          -----------+--------------------------- {1}       | Thu May 19 14:21:25 2016- {1,2}     | Fri May 20 14:21:25 2016- {1,2,3}   | Sat May 21 14:21:25 2016  {1,2,3,4} | Sun May 22 14:21:25 2016+ {1,2,3}   | Sat May 21 14:21:25 2016+ {1,2}     | Fri May 20 14:21:25 2016+ {1}       | Thu May 19 14:21:25 2016 (4 rows)  DROP INDEX idx_array;

BTW IMO it's better to check rum with REL_15_1 or REL_15_STABLE..

@sokolcatisokolcati deleted the PGPRO-7444 branchOctober 29, 2024 09:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kovdb75kovdb75Awaiting requested review from kovdb75

Assignees

@kovdb75kovdb75

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@MarinaPolyakova@kovdb75
[8]ページ先頭
©2009-2025 Movatter.jp