NotificationsYou must be signed in to change notification settings
Fork58
Star775

Commitaebcf8a

committed

[PGPRO-4224] Include guc.h instead of declaring guc variable

Windows build does some magic to export variables from postgres.exe and importthem into the extension. So it is better to include backend include file thanto redeclare variable in the extension code

1 parent5abca54 commitaebcf8aCopy full SHA for aebcf8a

File tree

1 file changed

-2

lines changed

src
- rumsort.c

1 file changed

-2

lines changed

`‎src/rumsort.c`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,13 @@`
`52`	`52`	`* Below are copied definitions from src/backend/utils/sort/tuplesort.c.`
`53`	`53`	`*/`
`54`	`54`
`55`		`-/* GUC variables */`
	`55`	`+/* GUC variables shouldn't be declared explicitely.`
	`56`	`+ Rather corresponigng include file should be include because it`
	`57`	`+ contains neccessary Windows export/import magic. And part of this`
	`58`	`+ magic should be done during postgres.exe compilation`
	`59`	`+*/`
`56`	`60`	`#ifdefTRACE_SORT`
`57`		`-externbooltrace_sort;`
	`61`	`+#include<utils/guc.h>`
`58`	`62`	`#endif`
`59`	`63`
`60`	`64`	`typedefstruct`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitaebcf8a

File tree

1 file changed

1 file changed

`‎src/rumsort.c`

0 commit comments