NotificationsYou must be signed in to change notification settings
Fork57
Star783

Commit78c348b

authored

Fix corruption when entry->buffer changed to nonleaf while unlocked. (#145)

The entry->buffer pointer is retrieved, but the underlying buffer can be modified by another thread before it's used, leading to invalid memory access and a segmentation fault. Now we check this case and return from the function.

1 parent2b0eb97 commit78c348bCopy full SHA for 78c348b

File tree

1 file changed

-1

lines changed

src
- rumget.c

1 file changed

-1

lines changed

`‎src/rumget.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -889,7 +889,14 @@ entryGetNextItem(RumState * rumstate, RumScanEntry entry, Snapshot snapshot)`
`889`	`889`
`890`	`890`	`LockBuffer(entry->buffer,RUM_SHARE);`
`891`	`891`	`page=BufferGetPage(entry->buffer);`
`892`		`-`
	`892`	`+if (!RumPageIsLeaf(page))`
	`893`	`+{`
	`894`	`+/*`
	`895`	`+ * Root page becomes non-leaf while we unlock it. just return.`
	`896`	`+ */`
	`897`	`+LockBuffer(entry->buffer,RUM_UNLOCK);`
	`898`	`+return;`
	`899`	`+}`
`893`	`900`	`PredicateLockPage(rumstate->index,BufferGetBlockNumber(entry->buffer),snapshot);`
`894`	`901`
`895`	`902`	`if (scanPage(rumstate,entry,&entry->curItem, false))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit78c348b

File tree

1 file changed

1 file changed

`‎src/rumget.c`

0 commit comments