Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

remove additional and useless loop for each relation file when do ptrack_get_pagemapset query#17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
funny-falcon merged 2 commits intopostgrespro:masterfromvegebird:mapset-fixes
Jun 27, 2022

Conversation

vegebird
Copy link
Contributor

remove additional and useless loop for each relation file when do ptrack_get_pagemapset query reported by#12

@codecov
Copy link

codecovbot commentedFeb 4, 2022
edited
Loading

Codecov Report

Merging#17 (a34e6c3) intomaster (6f1a27b) willincrease coverage by1.22%.
The diff coverage is100.00%.

❗ Current heada34e6c3 differs from pull request most recent head820380a. Consider uploading reports for the commit820380a to get more accurate results

@@            Coverage Diff             @@##           master      #17      +/-   ##==========================================+ Coverage   87.40%   88.63%   +1.22%==========================================  Files           2        2                Lines         381      431      +50     ==========================================+ Hits          333      382      +49- Misses         48       49       +1
Impacted FilesCoverage Δ
ptrack.c93.10% <100.00%> (+1.60%)⬆️
engine.c84.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6f1a27b...820380a. Read thecomment docs.

@vegebird
Copy link
ContributorAuthor

@ololobus Hello Alexey, could you please have a look at this PR ?
In rainy day scenarios, ptrack_get_pagemapset() may return error pagecount/pagemap for the changed relation files when do additional ptrack_map->entries[hash] checker and hash collision happens.

@ololobus
Copy link
Contributor

@funny-falcon@kulaginm have a look, when you'll have a chance, please

Copy link
Contributor

@funny-falconfunny-falcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well, I approve.
Please, accept suggestion on condition.

Co-authored-by: Sokolov Yura <funny.falcon@gmail.com>
@funny-falconfunny-falcon merged commite1d30bb intopostgrespro:masterJun 27, 2022
@vegebirdvegebird deleted the mapset-fixes branchJuly 6, 2022 02:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@funny-falconfunny-falconfunny-falcon approved these changes

@kulaginmkulaginmAwaiting requested review from kulaginm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vegebird@ololobus@funny-falcon

[8]ページ先頭

©2009-2025 Movatter.jp