- Notifications
You must be signed in to change notification settings - Fork5
Commitff75219
committed
Fix bugs in "restore.sql" script emitted in pg_dump tar output.
The tar output module did some very ugly and ultimately incorrect hackingon COPY commands to try to get them to work in the context of restoring adeconstructed tar archive. In particular, it would fail altogether fortable names containing any upper-case characters, since it smashed thecommand string to lower-case before modifying it (and, just to add insultto injury, did that in a way that would fail in multibyte encodings).I don't see any particular value in being flexible about the case of thecommand keywords, since the string will just have been created bydumpTableData, so let's get rid of the whole case-folding thing.Also, it doesn't seem to meet the POLA for the script to restore data onlyin COPY mode, so add \i commands to make it have comparable behavior in--inserts mode.Noted while looking at the tar-output code in connection with BrianWeaver's patch.1 parent997fa75 commitff75219
1 file changed
+35
-47
lines changedLines changed: 35 additions & 47 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
647 | 647 |
| |
648 | 648 |
| |
649 | 649 |
| |
650 |
| - | |
651 |
| - | |
652 |
| - | |
653 |
| - | |
| 650 | + | |
654 | 651 |
| |
655 | 652 |
| |
656 | 653 |
| |
657 | 654 |
| |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
658 | 662 |
| |
659 | 663 |
| |
660 |
| - | |
661 |
| - | |
662 |
| - | |
663 |
| - | |
664 |
| - | |
665 |
| - | |
666 |
| - | |
667 |
| - | |
668 |
| - | |
669 |
| - | |
670 |
| - | |
671 |
| - | |
672 |
| - | |
673 |
| - | |
674 |
| - | |
675 |
| - | |
676 |
| - | |
677 |
| - | |
678 |
| - | |
679 |
| - | |
680 |
| - | |
681 |
| - | |
682 |
| - | |
683 |
| - | |
684 |
| - | |
685 |
| - | |
686 |
| - | |
687 |
| - | |
688 |
| - | |
689 |
| - | |
690 |
| - | |
691 |
| - | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
692 | 668 |
| |
693 |
| - | |
694 |
| - | |
695 |
| - | |
696 |
| - | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
697 | 679 |
| |
698 |
| - | |
699 |
| - | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
700 | 690 |
| |
701 | 691 |
| |
702 | 692 |
| |
| |||
843 | 833 |
| |
844 | 834 |
| |
845 | 835 |
| |
846 |
| - | |
| 836 | + | |
847 | 837 |
| |
848 | 838 |
| |
849 | 839 |
| |
850 | 840 |
| |
851 | 841 |
| |
852 | 842 |
| |
853 |
| - | |
854 |
| - | |
855 |
| - | |
856 | 843 |
| |
857 |
| - | |
858 | 844 |
| |
859 | 845 |
| |
860 | 846 |
| |
| |||
882 | 868 |
| |
883 | 869 |
| |
884 | 870 |
| |
| 871 | + | |
| 872 | + | |
885 | 873 |
| |
886 | 874 |
| |
887 | 875 |
| |
|
0 commit comments
Comments
(0)