NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitff68b25

committed

Remove troublesome Asserts in cost_mergejoin().

While logically correct, these two Asserts could fail depending on thevagaries of floating-point arithmetic. In particular, on machines withfloating-point registers wider than standard "double" values, it waspossible for the compiler to compare a rounded-to-double value alreadystored in memory with an unrounded long double value still in a register.Given the preceding checks, these assertions aren't adding much, so let'sjust get rid of them rather than try to find a compiler-proof fix.Per report from Pavel Stehule.Given the lack of previous complaints, and the fact that only developerswould be likely to trip over it, I'm only going to change this in HEAD,even though the code has been like this for a long time.

1 parent89e850e commitff68b25Copy full SHA for ff68b25

File tree

1 file changed

-3

lines changed

src/backend/optimizer/path
- costsize.c

1 file changed

-3

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1933,9 +1933,6 @@ cost_mergejoin(MergePath path, PlannerInfo root, SpecialJoinInfo *sjinfo)`
`1933`	`1933`	`outerendsel=outer_rows /outer_path_rows;`
`1934`	`1934`	`innerendsel=inner_rows /inner_path_rows;`
`1935`	`1935`
`1936`		`-Assert(outerstartsel <=outerendsel);`
`1937`		`-Assert(innerstartsel <=innerendsel);`
`1938`		`-`
`1939`	`1936`	`/* cost of source data */`
`1940`	`1937`
`1941`	`1938`	`if (outersortkeys)/* do we need to sort outer? */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitff68b25

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/costsize.c`

0 commit comments