NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitfd658db

committed

Avoid incorrectly indicating exclusion constraint wait

INSERT ... ON CONFLICT's precheck may have to wait on the outcome ofanother insertion, which may or may not itself be a speculativeinsertion. This wait is not necessarily associated with an exclusionconstraint, but was always reported that way in log messages if the waithappened to involve a tuple that had no speculative token.Initially discovered through use of ON CONFLICT DO NOTHING, wherespurious references to exclusion constraints in log messages were morelikely.Patch by Peter Geoghegan.Reviewed by Julien Rouhaud.Back-patch to 9.5 where INSERT ... ON CONFLICT was added.

1 parent5bcc413 commitfd658dbCopy full SHA for fd658db

File tree

1 file changed

-2

lines changed

src/backend/executor
- execIndexing.c

1 file changed

-2

lines changed

`‎src/backend/executor/execIndexing.c‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -725,6 +725,7 @@ check_exclusion_or_unique_constraint(Relation heap, Relation index,`
`725`	`725`	`{`
`726`	`726`	`TransactionIdxwait;`
`727`	`727`	`ItemPointerDatactid_wait;`
	`728`	`+XLTW_Operreason_wait;`
`728`	`729`	`Datumexisting_values[INDEX_MAX_KEYS];`
`729`	`730`	`boolexisting_isnull[INDEX_MAX_KEYS];`
`730`	`731`	`char*error_new;`
`@@ -783,13 +784,14 @@ check_exclusion_or_unique_constraint(Relation heap, Relation index,`
`783`	`784`	`TransactionIdPrecedes(GetCurrentTransactionId(),xwait))))`
`784`	`785`	`{`
`785`	`786`	`ctid_wait=tup->t_data->t_ctid;`
	`787`	`+reason_wait=indexInfo->ii_ExclusionOps ?`
	`788`	`+XLTW_RecheckExclusionConstr :XLTW_InsertIndex;`
`786`	`789`	`index_endscan(index_scan);`
`787`	`790`	`if (DirtySnapshot.speculativeToken)`
`788`	`791`	`SpeculativeInsertionWait(DirtySnapshot.xmin,`
`789`	`792`	`DirtySnapshot.speculativeToken);`
`790`	`793`	`else`
`791`		`-XactLockTableWait(xwait,heap,&ctid_wait,`
`792`		`-XLTW_RecheckExclusionConstr);`
	`794`	`+XactLockTableWait(xwait,heap,&ctid_wait,reason_wait);`
`793`	`795`	`gotoretry;`
`794`	`796`	`}`
`795`	`797`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfd658db

File tree

1 file changed

1 file changed

`‎src/backend/executor/execIndexing.c‎`

0 commit comments