NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitfcb4bfd

committed

Reduce lock level for altering fillfactor

Fabrízio de Royes Mello and Simon Riggs

1 parent090b287 commitfcb4bfdCopy full SHA for fcb4bfd

File tree

3 files changed

+18

-18

lines changed

doc/src/sgml/ref
- alter_table.sgml
src
- backend/access/common
  - reloptions.c
- test/regress/expected
  - alter_table.out

3 files changed

+18

-18

lines changed

`‎doc/src/sgml/ref/alter_table.sgml`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -561,7 +561,7 @@ ALTER TABLE ALL IN TABLESPACE <replaceable class="PARAMETER">name</replaceable>`
`561`	`561`	`</para>`
`562`	`562`
`563`	`563`	`<para>`
`564`		`- Changing autovacuum storage parameters acquires a <literal>SHARE UPDATE EXCLUSIVE</literal> lock.`
	`564`	`+ Changingfillfactor andautovacuum storage parameters acquires a <literal>SHARE UPDATE EXCLUSIVE</literal> lock.`
`565`	`565`	`</para>`
`566`	`566`
`567`	`567`	`<note>`

`‎src/backend/access/common/reloptions.c`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ static relopt_int intRelOpts[] =`
`100`	`100`	`"fillfactor",`
`101`	`101`	`"Packs table pages only to this percentage",`
`102`	`102`	`RELOPT_KIND_HEAP,`
`103`		`-AccessExclusiveLock`
	`103`	`+ShareUpdateExclusiveLock/* since it applies only to later inserts */`
`104`	`104`	`},`
`105`	`105`	`HEAP_DEFAULT_FILLFACTOR,HEAP_MIN_FILLFACTOR,100`
`106`	`106`	`},`
`@@ -109,7 +109,7 @@ static relopt_int intRelOpts[] =`
`109`	`109`	`"fillfactor",`
`110`	`110`	`"Packs btree index pages only to this percentage",`
`111`	`111`	`RELOPT_KIND_BTREE,`
`112`		`-AccessExclusiveLock`
	`112`	`+ShareUpdateExclusiveLock/* since it applies only to later inserts */`
`113`	`113`	`},`
`114`	`114`	`BTREE_DEFAULT_FILLFACTOR,BTREE_MIN_FILLFACTOR,100`
`115`	`115`	`},`
`@@ -118,7 +118,7 @@ static relopt_int intRelOpts[] =`
`118`	`118`	`"fillfactor",`
`119`	`119`	`"Packs hash index pages only to this percentage",`
`120`	`120`	`RELOPT_KIND_HASH,`
`121`		`-AccessExclusiveLock`
	`121`	`+ShareUpdateExclusiveLock/* since it applies only to later inserts */`
`122`	`122`	`},`
`123`	`123`	`HASH_DEFAULT_FILLFACTOR,HASH_MIN_FILLFACTOR,100`
`124`	`124`	`},`
`@@ -127,7 +127,7 @@ static relopt_int intRelOpts[] =`
`127`	`127`	`"fillfactor",`
`128`	`128`	`"Packs gist index pages only to this percentage",`
`129`	`129`	`RELOPT_KIND_GIST,`
`130`		`-AccessExclusiveLock`
	`130`	`+ShareUpdateExclusiveLock/* since it applies only to later inserts */`
`131`	`131`	`},`
`132`	`132`	`GIST_DEFAULT_FILLFACTOR,GIST_MIN_FILLFACTOR,100`
`133`	`133`	`},`
`@@ -136,7 +136,7 @@ static relopt_int intRelOpts[] =`
`136`	`136`	`"fillfactor",`
`137`	`137`	`"Packs spgist index pages only to this percentage",`
`138`	`138`	`RELOPT_KIND_SPGIST,`
`139`		`-AccessExclusiveLock`
	`139`	`+ShareUpdateExclusiveLock/* since it applies only to later inserts */`
`140`	`140`	`},`
`141`	`141`	`SPGIST_DEFAULT_FILLFACTOR,SPGIST_MIN_FILLFACTOR,100`
`142`	`142`	`},`

`‎src/test/regress/expected/alter_table.out`

Lines changed: 12 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -2065,19 +2065,19 @@ select * from my_locks order by 1;`
`2065`	`2065`	`commit;`
`2066`	`2066`	`begin; alter table alterlock set (fillfactor = 100);`
`2067`	`2067`	`select * from my_locks order by 1;`
`2068`		`- relname \| max_lockmode`
`2069`		`------------+---------------------`
`2070`		`- alterlock \|AccessExclusiveLock`
`2071`		`- pg_toast \|AccessExclusiveLock`
	`2068`	`+ relname \|max_lockmode`
	`2069`	`+-----------+--------------------------`
	`2070`	`+ alterlock \|ShareUpdateExclusiveLock`
	`2071`	`+ pg_toast \|ShareUpdateExclusiveLock`
`2072`	`2072`	`(2 rows)`
`2073`	`2073`
`2074`	`2074`	`commit;`
`2075`	`2075`	`begin; alter table alterlock reset (fillfactor);`
`2076`	`2076`	`select * from my_locks order by 1;`
`2077`		`- relname \| max_lockmode`
`2078`		`------------+---------------------`
`2079`		`- alterlock \|AccessExclusiveLock`
`2080`		`- pg_toast \|AccessExclusiveLock`
	`2077`	`+ relname \|max_lockmode`
	`2078`	`+-----------+--------------------------`
	`2079`	`+ alterlock \|ShareUpdateExclusiveLock`
	`2080`	`+ pg_toast \|ShareUpdateExclusiveLock`
`2081`	`2081`	`(2 rows)`
`2082`	`2082`
`2083`	`2083`	`commit;`
`@@ -2110,10 +2110,10 @@ rollback;`
`2110`	`2110`	`-- test that mixing options with different lock levels works as expected`
`2111`	`2111`	`begin; alter table alterlock set (autovacuum_enabled = off, fillfactor = 80);`
`2112`	`2112`	`select * from my_locks order by 1;`
`2113`		`- relname \| max_lockmode`
`2114`		`------------+---------------------`
`2115`		`- alterlock \|AccessExclusiveLock`
`2116`		`- pg_toast \|AccessExclusiveLock`
	`2113`	`+ relname \|max_lockmode`
	`2114`	`+-----------+--------------------------`
	`2115`	`+ alterlock \|ShareUpdateExclusiveLock`
	`2116`	`+ pg_toast \|ShareUpdateExclusiveLock`
`2117`	`2117`	`(2 rows)`
`2118`	`2118`
`2119`	`2119`	`commit;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfcb4bfd

File tree

3 files changed

3 files changed

`‎doc/src/sgml/ref/alter_table.sgml`

`‎src/backend/access/common/reloptions.c`

`‎src/test/regress/expected/alter_table.out`

0 commit comments