- Notifications
You must be signed in to change notification settings - Fork5
Commitfaf5cee
committed
Fix another Assert issue exposed by CLOBBER_CACHE_ALWAYS.
plpgsql's exec_stmt_execsql was Assert'ing that a CachedPlanSource wasis_valid immediately after exec_prepare_plan. The risk factor in this caseis that after building the prepared statement, exec_prepare_plan callsexec_simple_check_plan, which might try to generate a generic plan --- andwith CLOBBER_CACHE_ALWAYS or other unusual causes of invalidation, thatcould result in an invalidation. However, that path could only be takenfor a SELECT query, for which we need not set mod_stmt. So in this caseI think it's best to just remove the Assert; it's okay to look at aslightly-stale querytree for what we need here. Per buildfarm testing.1 parentc4ae968 commitfaf5cee
1 file changed
+0
-1
lines changedLines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3027 | 3027 |
| |
3028 | 3028 |
| |
3029 | 3029 |
| |
3030 |
| - | |
3031 | 3030 |
| |
3032 | 3031 |
| |
3033 | 3032 |
| |
|
0 commit comments
Comments
(0)