NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf96baba

committed

While I was running some tests in psql, trying to figure out how to change

the query string to handle any length, I discovered that under certainconditions, psql will core dump when handling long strings. Thus, thepatch. It was caused by a buffer overrun, probably not noticeable in a lotof cases, but pretty noticeable in mine.Problem was caused by the fact that the length check is only performed afterthe check for a ; to get the end of the query and execute.Cheers...MikeA

1 parenta2bb39c commitf96babaCopy full SHA for f96baba

File tree

1 file changed

-2

lines changed

src/bin/psql
- psql.c

1 file changed

-2

lines changed

`‎src/bin/psql/psql.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/bin/psql/Attic/psql.c,v 1.187 1999/07/19 21:06:19 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/Attic/psql.c,v 1.188 1999/07/20 17:20:43 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -2705,7 +2705,8 @@ MainLoop(PsqlSettings pset, char query, FILE *source)`
`2705`	`2705`	`charhold_char=line[i+thislen];`
`2706`	`2706`
`2707`	`2707`	`line[i+thislen]='\0';`
`2708`		`-if (query_start[0]!='\0')`
	`2708`	`+if ((query_start[0]!='\0')&&`
	`2709`	`+(strlen(query)+strlen(query_start) <=MAX_QUERY_BUFFER))`
`2709`	`2710`	`{`
`2710`	`2711`	`if (query[0]!='\0')`
`2711`	`2712`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf96baba

File tree

1 file changed

1 file changed

`‎src/bin/psql/psql.c`

0 commit comments