Commitf92bbb8

committed

Fix incorrect arguments for gist_box_penalty call. The bug could be observed

only for secondary page split (i.e. for non-first columns of index) Patch by Paul Ramsey <pramsey@opengeo.org>

1 parentdacaeff commitf92bbb8Copy full SHA for f92bbb8

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Portions Copyright (c) 1994, Regents of the University of California`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- *$PostgreSQL: pgsql/src/backend/access/gist/gistproc.c,v 1.17 2009/06/11 14:48:53 momjian Exp $`
	`13`	`+ *$PostgreSQL: pgsql/src/backend/access/gist/gistproc.c,v 1.18 2009/09/18 14:01:56 teodor Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -234,9 +234,9 @@ chooseLR(GIST_SPLITVEC *v,`
`234`	`234`	`NULL,NULL,InvalidOffsetNumber, FALSE);`
`235`	`235`
`236`	`236`	`gistentryinit(addon,BoxPGetDatum(union1),NULL,NULL,InvalidOffsetNumber, FALSE);`
`237`		`-DirectFunctionCall3(gist_box_penalty,PointerGetDatum(&oldUnion),PointerGetDatum(&union1),PointerGetDatum(&p1));`
	`237`	`+DirectFunctionCall3(gist_box_penalty,PointerGetDatum(&oldUnion),PointerGetDatum(&addon),PointerGetDatum(&p1));`
`238`	`238`	`gistentryinit(addon,BoxPGetDatum(union2),NULL,NULL,InvalidOffsetNumber, FALSE);`
`239`		`-DirectFunctionCall3(gist_box_penalty,PointerGetDatum(&oldUnion),PointerGetDatum(&union2),PointerGetDatum(&p2));`
	`239`	`+DirectFunctionCall3(gist_box_penalty,PointerGetDatum(&oldUnion),PointerGetDatum(&addon),PointerGetDatum(&p2));`
`240`	`240`
`241`	`241`	`if ((v->spl_ldatum_exists&&p1>p2)\|\| (v->spl_rdatum_exists&&p1<p2))`
`242`	`242`	`firstToLeft= false;`

Comments

(0)