Commitf7b711c

committed

Cosmetic fixes for hash index write-ahead logging.

Amit Kapila. One of these was reported by Tom Lane.Discussion:http://postgr.es/m/5515.1489514099@sss.pgh.pa.us

1 parentaefeb68 commitf7b711cCopy full SHA for f7b711c

File tree

-4

lines changed

-4

lines changed

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -365,9 +365,6 @@ try to split the bucket again until the prior split is finished. In other`
`365`	`365`	`words, a bucket can be in the middle of being split for some time, but it can't`
`366`	`366`	`be in the middle of two splits at the same time.`
`367`	`367`
`368`		`-Although we can survive a failure to split a bucket, a crash is likely to`
`369`		`-corrupt the index, since hash indexes are not yet WAL-logged.`
`370`		`-`
`371`	`368`	`The fourth operation is garbage collection (bulk deletion):`
`372`	`369`
`373`	`370`	`next bucket := 0`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -975,7 +975,7 @@ _hash_expandtable(Relation rel, Buffer metabuf)`
`975`	`975`	`* hash indexes sequentially anyway, that probably doesn't matter.`
`976`	`976`	`*`
`977`	`977`	`* XXX It's annoying that this code is executed with the metapage lock held.`
`978`		`- * We need to interlock against_hash_getovflpage() adding a new overflow page`
	`978`	`+ * We need to interlock against_hash_addovflpage() adding a new overflow page`
`979`	`979`	`* concurrently, but it'd likely be better to use LockRelationForExtension`
`980`	`980`	`* for the purpose. OTOH, adding a splitpoint is a very infrequent operation,`
`981`	`981`	`* so it may not be worth worrying about.`

Comments

(0)