NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf663935

committed

One last missing quoting bug in pg_dump:

now that sequence names are properly quoted for field defaults, mixedcase sequence names are generated. These are properly quoted in theCREATE SEQUENCE lines, but not in the SELECT nextval lines, as perbelow:CREATE SEQUENCE "Teams_TeamID_seq" start 10 increment 1 maxvalue2147483647 minvalue 1 cache 1 ;SELECT nextval ('Teams_TeamID_seq');This needs to be:SELECT nextval ('"Teams_TeamID_seq"');Patch included below.--Ross J. Reedstrom, Ph.D., <reedstrm@rice.edu>

1 parentbe38f75 commitf663935Copy full SHA for f663935

File tree

2 files changed

-4

lines changed

doc
- TODO
src/bin/pg_dump
- pg_dump.c

2 files changed

-4

lines changed

`‎doc/TODO`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ TYPES`
`111`	`111`	`* Add non-large-object binary field`
`112`	`112`	`* Add index on NUMERIC/DECIMAL type`
`113`	`113`	`* Make Absolutetime/Relativetime int4 because time_t can be int8 on some ports`
`114`		`-* Functions returning sets don't really work right(see TODO.detail/functions)`
	`114`	`+* Functions returning sets don't really work right(see TODO.detail/function)`
`115`	`115`
`116`	`116`	`VIEWS`
`117`	`117`
`@@ -157,7 +157,7 @@ CLIENTS`
`157`	`157`	`* Update reltuples from COPY command`
`158`	`158`	`* Allow psql \copy to allow delimiters`
`159`	`159`	`* Add a function to return the last inserted oid, for use in psql scripts`
`160`		`-* Allow psql to print nulls as distinct from ""(see TODO.detail/nulls)`
	`160`	`+* Allow psql to print nulls as distinct from ""(see TODO.detail/null)`
`161`	`161`	`* PQrequestCancel() be able to terminate backend waiting for lock`
`162`	`162`
`163`	`163`	`EXOTIC FEATURES`

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`*`
`22`	`22`	`*`
`23`	`23`	`* IDENTIFICATION`
`24`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.119 1999/09/01 23:05:20 momjian Exp $`
	`24`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.120 1999/09/23 19:11:09 momjian Exp $`
`25`	`25`	`*`
`26`	`26`	`* Modifications - 6/10/96 - dave@bensoft.com - version 1.13.dhb`
`27`	`27`	`*`
`@@ -3192,7 +3192,7 @@ dumpSequence(FILE *fout, TableInfo tbinfo)`
`3192`	`3192`	`if (called=='f')`
`3193`	`3193`	`return;/* nothing to do more */`
`3194`	`3194`
`3195`		`-sprintf(query,"SELECT nextval ('%s');\n",tbinfo.relname);`
	`3195`	`+sprintf(query,"SELECT nextval ('%s');\n",fmtId(tbinfo.relname,force_quotes));`
`3196`	`3196`	`fputs(query,fout);`
`3197`	`3197`
`3198`	`3198`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf663935

File tree

2 files changed

2 files changed

`‎doc/TODO`

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments