NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf62be40

committed

On second thought, we'd better just drop these tests altogether.

Further experimentation reveals that my previous change didn't fix theissue entirely: these tests would still fail at the spring-forward DSTtransition. There doesn't seem to be any great value in testing thisspecific issue for both timestamp and timestamptz, so just lose thelatter tests.

1 parent362f731 commitf62be40Copy full SHA for f62be40

File tree

2 files changed

-49

lines changed

src/test/regress
- expected
  - horology.out
- sql
  - horology.sql

2 files changed

-49

lines changed

`‎src/test/regress/expected/horology.out`

Lines changed: 0 additions & 42 deletions

Original file line number	Diff line number	Diff line change
`@@ -639,54 +639,12 @@ SELECT (timestamp with time zone 'today' = (timestamp with time zone 'tomorrow'`
`639`	`639`	`t`
`640`	`640`	`(1 row)`
`641`	`641`
`642`		`-SELECT (timestamp with time zone 'today 10:30-08' = timestamptz(date 'today', time with time zone '10:30 -08')) as "True";`
`643`		`- True`
`644`		`-------`
`645`		`- t`
`646`		`-(1 row)`
`647`		`-`
`648`		`-SELECT (timestamp with time zone '10:30-08 today' = timestamptz(date 'today', time with time zone '10:30 -08')) as "True";`
`649`		`- True`
`650`		`-------`
`651`		`- t`
`652`		`-(1 row)`
`653`		`-`
`654`	`642`	`SELECT (timestamp with time zone 'tomorrow' = (timestamp with time zone 'yesterday' + interval '2 days')) as "True";`
`655`	`643`	`True`
`656`	`644`	`------`
`657`	`645`	`t`
`658`	`646`	`(1 row)`
`659`	`647`
`660`		`-SELECT (timestamp with time zone 'tomorrow 10:30-08' = (timestamp with time zone 'today 10:30-08' + interval '1 day')) as "True";`
`661`		`- True`
`662`		`-------`
`663`		`- t`
`664`		`-(1 row)`
`665`		`-`
`666`		`-SELECT (timestamp with time zone '10:30-08 tomorrow' = (timestamp with time zone 'today 10:30-08' + interval '1 day')) as "True";`
`667`		`- True`
`668`		`-------`
`669`		`- t`
`670`		`-(1 row)`
`671`		`-`
`672`		`-SELECT (timestamp with time zone 'yesterday 12:34:56-7' = timestamptz(date 'yesterday', time with time zone '12:34:56-7')) as "True";`
`673`		`- True`
`674`		`-------`
`675`		`- t`
`676`		`-(1 row)`
`677`		`-`
`678`		`-SELECT (timestamp with time zone '12:34:56 yesterday -7' = timestamptz(date 'yesterday', time with time zone '12:34:56-7')) as "True";`
`679`		`- True`
`680`		`-------`
`681`		`- t`
`682`		`-(1 row)`
`683`		`-`
`684`		`-SELECT (timestamp with time zone '12:34:56-7 yesterday' = timestamptz(date 'yesterday', time with time zone '12:34:56-7')) as "True";`
`685`		`- True`
`686`		`-------`
`687`		`- t`
`688`		`-(1 row)`
`689`		`-`
`690`	`648`	`SELECT (timestamp with time zone 'tomorrow' > 'now') as "True";`
`691`	`649`	`True`
`692`	`650`	`------`

`‎src/test/regress/sql/horology.sql`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -118,14 +118,7 @@ SELECT timestamp with time zone '1999-12-01' + interval '1 month - 1 second' AS`
`118`	`118`
`119`	`119`	`SELECT (timestamp with time zone'today'= (timestamp with time zone'yesterday'+ interval'1 day'))as"True";`
`120`	`120`	`SELECT (timestamp with time zone'today'= (timestamp with time zone'tomorrow'- interval'1 day'))as"True";`
`121`		`-SELECT (timestamp with time zone'today 10:30-08'=timestamptz(date'today',time with time zone'10:30 -08'))as"True";`
`122`		`-SELECT (timestamp with time zone'10:30-08 today'=timestamptz(date'today',time with time zone'10:30 -08'))as"True";`
`123`	`121`	`SELECT (timestamp with time zone'tomorrow'= (timestamp with time zone'yesterday'+ interval'2 days'))as"True";`
`124`		`-SELECT (timestamp with time zone'tomorrow 10:30-08'= (timestamp with time zone'today 10:30-08'+ interval'1 day'))as"True";`
`125`		`-SELECT (timestamp with time zone'10:30-08 tomorrow'= (timestamp with time zone'today 10:30-08'+ interval'1 day'))as"True";`
`126`		`-SELECT (timestamp with time zone'yesterday 12:34:56-7'=timestamptz(date'yesterday',time with time zone'12:34:56-7'))as"True";`
`127`		`-SELECT (timestamp with time zone'12:34:56 yesterday -7'=timestamptz(date'yesterday',time with time zone'12:34:56-7'))as"True";`
`128`		`-SELECT (timestamp with time zone'12:34:56-7 yesterday'=timestamptz(date'yesterday',time with time zone'12:34:56-7'))as"True";`
`129`	`122`	`SELECT (timestamp with time zone'tomorrow'>'now')as"True";`
`130`	`123`
`131`	`124`	`-- timestamp with time zone, interval arithmetic around DST change`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf62be40

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/horology.out`

`‎src/test/regress/sql/horology.sql`

0 commit comments