NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf4b4a46

committed

Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar" is simple.

It's not clear if this situation can occur in plpgsql other than via theEXECUTE USING case Heikki illustrated, which I will shortly close off.However, ignoring the intoClause if it's there is surely wrong, so let'spatch it for safety.Backpatch to 8.3, which is as far back as this code has a PlannedStmtto deal with. There might be another way to make an equivalent testbefore that, but since this is just preventing hypothetical bugs,I'm not going to obsess about it.

1 parent3869e9a commitf4b4a46Copy full SHA for f4b4a46

File tree

1 file changed

-1

lines changed

src/pl/plpgsql/src
- pl_exec.c

1 file changed

-1

lines changed

`‎src/pl/plpgsql/src/pl_exec.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.265 2010/08/1917:31:43 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.266 2010/08/1918:10:48 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -5280,6 +5280,8 @@ exec_simple_check_plan(PLpgSQL_expr *expr)`
`5280`	`5280`	`*/`
`5281`	`5281`	`if (!IsA(stmt,PlannedStmt))`
`5282`	`5282`	`return;`
	`5283`	`+if (stmt->commandType!=CMD_SELECT\|\|stmt->intoClause)`
	`5284`	`+return;`
`5283`	`5285`	`plan=stmt->planTree;`
`5284`	`5286`	`if (!IsA(plan,Result))`
`5285`	`5287`	`return;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf4b4a46

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/pl_exec.c`

0 commit comments