NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf369207

committed

Fix another portability issue in pg_basebackup.

The target of sscanf with a %o format had better be of integer width,but "mode_t" conceivably isn't that. Another compiler warning seenonly on some platforms; this one I think is potentially a real bugand not just a warning.

1 parentdd5f0db commitf369207Copy full SHA for f369207

File tree

1 file changed

-3

lines changed

src/bin/pg_basebackup
- pg_basebackup.c

1 file changed

-3

lines changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ ReceiveAndUnpackTarFile(PGconn conn, PGresult res, int rownum)`
`483`	`483`
`484`	`484`	`if (file==NULL)`
`485`	`485`	`{`
`486`		`-mode_tfilemode;`
	`486`	`+intfilemode;`
`487`	`487`
`488`	`488`	`/*`
`489`	`489`	`* No current file, so this must be the header for a new file`
`@@ -540,7 +540,7 @@ ReceiveAndUnpackTarFile(PGconn conn, PGresult res, int rownum)`
`540`	`540`	`disconnect_and_exit(1);`
`541`	`541`	`}`
`542`	`542`	`#ifndefWIN32`
`543`		`-if (chmod(fn,filemode))`
	`543`	`+if (chmod(fn,(mode_t)filemode))`
`544`	`544`	`fprintf(stderr,_("%s: could not set permissions on directory \"%s\": %s\n"),`
`545`	`545`	`progname,fn,strerror(errno));`
`546`	`546`	`#endif`
`@@ -580,7 +580,7 @@ ReceiveAndUnpackTarFile(PGconn conn, PGresult res, int rownum)`
`580`	`580`	`}`
`581`	`581`
`582`	`582`	`#ifndefWIN32`
`583`		`-if (chmod(fn,filemode))`
	`583`	`+if (chmod(fn,(mode_t)filemode))`
`584`	`584`	`fprintf(stderr,_("%s: could not set permissions on file \"%s\": %s\n"),`
`585`	`585`	`progname,fn,strerror(errno));`
`586`	`586`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf369207

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

0 commit comments