NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf145454

committed

Ensure _dosmaperr() actually sets errno correctly.

If logging is enabled, either ereport() or fprintf() might stomp on errnointernally, causing this function to return the wrong result. That mightonly end in a misleading error report, but in any code that's examiningerrno to decide what to do next, the consequences could be far graver.This has been broken since the very first version of this file in 2006... it's a bit astonishing that we didn't identify this long ago.Reported by Amit Kapila, though this isn't his proposed fix.

1 parentb7212c9 commitf145454Copy full SHA for f145454

File tree

1 file changed

-3

lines changed

src/port
- win32error.c

1 file changed

-3

lines changed

`‎src/port/win32error.c`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,14 +179,16 @@ _dosmaperr(unsigned long e)`
`179`	`179`	`{`
`180`	`180`	`if (doserrors[i].winerr==e)`
`181`	`181`	`{`
`182`		`-errno=doserrors[i].doserr;`
	`182`	`+intdoserr=doserrors[i].doserr;`
	`183`	`+`
`183`	`184`	`#ifndefFRONTEND`
`184`	`185`	`ereport(DEBUG5,`
`185`	`186`	`(errmsg_internal("mapped win32 error code %lu to %d",`
`186`		`-e,errno)));`
	`187`	`+e,doserr)));`
`187`	`188`	`#elifFRONTEND_DEBUG`
`188`		`-fprintf(stderr,_("mapped win32 error code %lu to %d"),e,errno);`
	`189`	`+fprintf(stderr,_("mapped win32 error code %lu to %d"),e,doserr);`
`189`	`190`	`#endif`
	`191`	`+errno=doserr;`
`190`	`192`	`return;`
`191`	`193`	`}`
`192`	`194`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf145454

File tree

1 file changed

1 file changed

`‎src/port/win32error.c`

0 commit comments