NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf0e766b

committed

Fix memory leak in GIN index scans.

The code had a query-lifespan memory leak when encountering GIN entriesthat have posting lists (rather than posting trees, ie, there are arelatively small number of heap tuples containing this index key value).With a suitable data distribution this could add up to a lot of leakage.Problem seems to have been introduced by commit36a35c5, so back-patchto 9.4.Julien Rouhaud

1 parent6f0d6a5 commitf0e766bCopy full SHA for f0e766b

File tree

1 file changed

-0

lines changed

src/backend/access/gin
- ginget.c

1 file changed

-0

lines changed

`‎src/backend/access/gin/ginget.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -281,6 +281,7 @@ collectMatchBitmap(GinBtreeData btree, GinBtreeStack stack,`
`281`	`281`	`ipd=ginReadTuple(btree->ginstate,scanEntry->attnum,itup,&nipd);`
`282`	`282`	`tbm_add_tuples(scanEntry->matchBitmap,ipd,nipd, false);`
`283`	`283`	`scanEntry->predictNumberResult+=GinGetNPosting(itup);`
	`284`	`+pfree(ipd);`
`284`	`285`	`}`
`285`	`286`
`286`	`287`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf0e766b

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginget.c`

0 commit comments