NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitf0bfc02

committed

Remove unnecessary lo_lseek call in lo_open. Apparently there was once

a need for it back in the neolithic era, but it's certainly dead code inany PG release we would recognize as such. Since it forces an additionalnetwork round trip to the backend, getting rid of it should provide somesmall performance improvement for large-object-using clients.

1 parent56aa84a commitf0bfc02Copy full SHA for f0bfc02

File tree

1 file changed

-6

lines changed

src/interfaces/libpq
- fe-lobj.c

1 file changed

-6

lines changed

`‎src/interfaces/libpq/fe-lobj.c`

Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-lobj.c,v 1.54 2005/10/15 02:49:48 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-lobj.c,v 1.55 2006/03/02 21:56:14 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -76,11 +76,6 @@ lo_open(PGconn *conn, Oid lobjId, int mode)`
`76`	`76`	`if (PQresultStatus(res)==PGRES_COMMAND_OK)`
`77`	`77`	`{`
`78`	`78`	`PQclear(res);`
`79`		`-`
`80`		`-/* have to do this to reset offset in shared fd cache */`
`81`		`-/* but only if fd is valid */`
`82`		`-if (fd >=0&&lo_lseek(conn,fd,0L,SEEK_SET)<0)`
`83`		`-return-1;`
`84`	`79`	`returnfd;`
`85`	`80`	`}`
`86`	`81`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf0bfc02

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-lobj.c`

0 commit comments