NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitee65565

committed

Inline ginCompareItemPointers function for speed.

ginCompareItemPointers function is called heavily in gin index scans -inlining it speeds up some kind of queries a lot.

1 parentd51b271 commitee65565Copy full SHA for ee65565

File tree

2 files changed

+24

-20

lines changed

src
- backend/access/gin
  - gindatapage.c
- include/access
  - gin_private.h

2 files changed

+24

-20

lines changed

`‎src/backend/access/gin/gindatapage.c‎`

Lines changed: 0 additions & 19 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,25 +17,6 @@`
`17`	`17`	`#include"access/gin_private.h"`
`18`	`18`	`#include"utils/rel.h"`
`19`	`19`
`20`		`-int`
`21`		`-ginCompareItemPointers(ItemPointera,ItemPointerb)`
`22`		`-{`
`23`		`-BlockNumberba=GinItemPointerGetBlockNumber(a);`
`24`		`-BlockNumberbb=GinItemPointerGetBlockNumber(b);`
`25`		`-`
`26`		`-if (ba==bb)`
`27`		`-{`
`28`		`-OffsetNumberoa=GinItemPointerGetOffsetNumber(a);`
`29`		`-OffsetNumberob=GinItemPointerGetOffsetNumber(b);`
`30`		`-`
`31`		`-if (oa==ob)`
`32`		`-return0;`
`33`		`-return (oa>ob) ?1 :-1;`
`34`		`-}`
`35`		`-`
`36`		`-return (ba>bb) ?1 :-1;`
`37`		`-}`
`38`		`-`
`39`	`20`	`/*`
`40`	`21`	`* Merge two ordered arrays of itempointers, eliminating any duplicates.`
`41`	`22`	`* Returns the number of items in the result.`

`‎src/include/access/gin_private.h‎`

Lines changed: 24 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,6 @@ extern void ginEntryFillRoot(GinBtree btree, Buffer root, Buffer lbuf, Buffer rb`
`530`	`530`	`externIndexTupleginPageGetLinkItup(Bufferbuf);`
`531`	`531`
`532`	`532`	`/* gindatapage.c */`
`533`		`-externintginCompareItemPointers(ItemPointera,ItemPointerb);`
`534`	`533`	`externuint32ginMergeItemPointers(ItemPointerData*dst,`
`535`	`534`	`ItemPointerData*a,uint32na,`
`536`	`535`	`ItemPointerData*b,uint32nb);`
`@@ -724,4 +723,28 @@ extern void ginHeapTupleFastCollect(GinState *ginstate,`
`724`	`723`	`externvoidginInsertCleanup(GinState*ginstate,`
`725`	`724`	`boolvac_delay,IndexBulkDeleteResult*stats);`
`726`	`725`
	`726`	`+/*`
	`727`	`+ * Merging the results of several gin scans compares item pointers a lot,`
	`728`	`+ * so we want this to be inlined. But if the compiler doesn't support that,`
	`729`	`+ * fall back on the non-inline version from itemptr.c. See STATIC_IF_INLINE in`
	`730`	`+ * c.h.`
	`731`	`+ */`
	`732`	`+#ifdefPG_USE_INLINE`
	`733`	`+staticinlineint`
	`734`	`+ginCompareItemPointers(ItemPointera,ItemPointerb)`
	`735`	`+{`
	`736`	`+uint64ia= (uint64)a->ip_blkid.bi_hi <<32 \| (uint64)a->ip_blkid.bi_lo <<16 \|a->ip_posid;`
	`737`	`+uint64ib= (uint64)b->ip_blkid.bi_hi <<32 \| (uint64)b->ip_blkid.bi_lo <<16 \|b->ip_posid;`
	`738`	`+`
	`739`	`+if (ia==ib)`
	`740`	`+return0;`
	`741`	`+elseif (ia>ib)`
	`742`	`+return1;`
	`743`	`+else`
	`744`	`+return-1;`
	`745`	`+}`
	`746`	`+#else`
	`747`	`+#defineginCompareItemPointers(a,b) ItemPointerCompare(a, b)`
	`748`	`+#endif/* PG_USE_INLINE */`
	`749`	`+`
`727`	`750`	`#endif/* GIN_PRIVATE_H */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitee65565

File tree

2 files changed

2 files changed

`‎src/backend/access/gin/gindatapage.c‎`

`‎src/include/access/gin_private.h‎`

0 commit comments