NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commiteda5e90

committed

Don't trust CreateFileMapping() to clear the error code on success.

We must test GetLastError() even when CreateFileMapping() returns anon-null handle. If that value were left over from some previous systemcall, we might be fooled into thinking the segment already existed.Experimentation on Windows 7 suggests that CreateFileMapping() clearsthe error code on success, but it is not documented to do so, so let'snot rely on that happening in all Windows releases.Amit KapilaDiscussion: <20811.1474390987@sss.pgh.pa.us>

1 parent93528f7 commiteda5e90Copy full SHA for eda5e90

File tree

1 file changed

-0

lines changed

src/backend/storage/ipc
- dsm_impl.c

1 file changed

-0

lines changed

`‎src/backend/storage/ipc/dsm_impl.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -681,6 +681,9 @@ dsm_impl_windows(dsm_op op, dsm_handle handle, Size request_size,`
`681`	`681`	`#endif`
`682`	`682`	`size_low= (DWORD)request_size;`
`683`	`683`
	`684`	`+/* CreateFileMapping might not clear the error code on success */`
	`685`	`+SetLastError(0);`
	`686`	`+`
`684`	`687`	`hmap=CreateFileMapping(INVALID_HANDLE_VALUE,/* Use the pagefile */`
`685`	`688`	`NULL,/* Default security attrs */`
`686`	`689`	`PAGE_READWRITE,/* Memory is read/write */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commiteda5e90

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/dsm_impl.c`

0 commit comments