Commited154fc

committed

fixes regarding PATHMAN_CONFIG_PARAMS in refresh_pathman_relation_info()

1 parentdbcce6e commited154fcCopy full SHA for ed154fc

File tree

+12

-7

lines changed

+12

-7

lines changed

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -622,7 +622,7 @@ pathman_config_contains_relation(Oid relid, Datum values, bool isnull,`
`622`	`622`	`}`
`623`	`623`
`624`	`624`	`/*`
`625`		`- * Return'enable_parent' parameter of relation`
	`625`	`+ * Returnadditional parameters from PATHMAN_CONFIG_PARAMS.`
`626`	`626`	`*/`
`627`	`627`	`bool`
`628`	`628`	`read_pathman_params(Oidrelid,Datumvalues,boolisnull)`
`@@ -632,7 +632,7 @@ read_pathman_params(Oid relid, Datum values, bool isnull)`
`632`	`632`	`ScanKeyDatakey[1];`
`633`	`633`	`Snapshotsnapshot;`
`634`	`634`	`HeapTuplehtup;`
`635`		`-boolresult= false;`
	`635`	`+boolrow_found= false;`
`636`	`636`
`637`	`637`	`ScanKeyInit(&key[0],`
`638`	`638`	`Anum_pathman_config_params_partrel,`
`@@ -643,19 +643,20 @@ read_pathman_params(Oid relid, Datum values, bool isnull)`
`643`	`643`	`snapshot=RegisterSnapshot(GetLatestSnapshot());`
`644`	`644`	`scan=heap_beginscan(rel,snapshot,1,key);`
`645`	`645`
	`646`	`+/* There should be just 1 row */`
`646`	`647`	`if ((htup=heap_getnext(scan,ForwardScanDirection))!=NULL)`
`647`	`648`	`{`
`648`	`649`	`/* Extract data if necessary */`
`649`	`650`	`heap_deform_tuple(htup,RelationGetDescr(rel),values,isnull);`
`650`		`-result= true;`
	`651`	`+row_found= true;`
`651`	`652`	`}`
`652`	`653`
`653`	`654`	`/* Clean resources */`
`654`	`655`	`heap_endscan(scan);`
`655`	`656`	`UnregisterSnapshot(snapshot);`
`656`	`657`	`heap_close(rel,AccessShareLock);`
`657`	`658`
`658`		`-returnresult;`
	`659`	`+returnrow_found;`
`659`	`660`	`}`
`660`	`661`
`661`	`662`	`/*`

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -160,14 +160,18 @@ refresh_pathman_relation_info(Oid relid,`
`160`	`160`
`161`	`161`	`pfree(prel_children);`
`162`	`162`
`163`		`-/*`
`164`		`- * Read additional parameters ('enable_parent' and 'auto' at the moment)`
`165`		`- */`
	`163`	`+/* Read additional parameters ('enable_parent' and 'auto' at the moment) */`
`166`	`164`	`if (read_pathman_params(relid,param_values,param_isnull))`
`167`	`165`	`{`
`168`	`166`	`prel->enable_parent=param_values[Anum_pathman_config_params_enable_parent-1];`
`169`	`167`	`prel->auto_partition=param_values[Anum_pathman_config_params_auto-1];`
`170`	`168`	`}`
	`169`	`+/* Else set default values if they cannot be found */`
	`170`	`+else`
	`171`	`+{`
	`172`	`+prel->enable_parent= false;`
	`173`	`+prel->auto_partition= true;`
	`174`	`+}`
`171`	`175`
`172`	`176`	`/* We've successfully built a cache entry */`
`173`	`177`	`prel->valid= true;`

Comments

(0)