NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitec903d2

committed

Improve comment.

Based on the old comment, it took me a while to figure out what theproblem was. The importnat detail is that SSL_read() can return WANT_READeven though some raw data was received from the socket.

1 parent73cfa37 commitec903d2Copy full SHA for ec903d2

File tree

1 file changed

-3

lines changed

src/interfaces/libpq
- fe-misc.c

1 file changed

-3

lines changed

`‎src/interfaces/libpq/fe-misc.c‎`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -744,9 +744,10 @@ pqReadData(PGconn *conn)`
`744`	`744`	`* the file selected for reading already.`
`745`	`745`	`*`
`746`	`746`	`* In SSL mode it's even worse: SSL_read() could say WANT_READ and then`
`747`		`- * data could arrive before we make the pqReadReady() test. So we must`
`748`		`- * play dumb and assume there is more data, relying on the SSL layer to`
`749`		`- * detect true EOF.`
	`747`	`+ * data could arrive before we make the pqReadReady() test, but the`
	`748`	`+ * second SSL_read() could still say WANT_READ because the data received`
	`749`	`+ * was not a complete SSL record. So we must play dumb and assume there`
	`750`	`+ * is more data, relying on the SSL layer to detect true EOF.`
`750`	`751`	`*/`
`751`	`752`
`752`	`753`	`#ifdefUSE_SSL`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitec903d2

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-misc.c‎`

0 commit comments