Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitec786c6

Browse files
committed
I neglected many comments in the log+seg -> 64-bit segno patch. Fix.
Reported by Amit Kapila.
1 parent7700b82 commitec786c6

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

‎src/backend/access/transam/xlog.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2479,7 +2479,7 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)
24792479
/*
24802480
* Create a new XLOG file segment by copying a pre-existing one.
24812481
*
2482-
*log, seg: identify segment to be created.
2482+
*destsegno: identify segment to be created.
24832483
*
24842484
* srcTLI, srclog, srcseg: identify segment to be copied (could be from
24852485
*a different timeline)
@@ -2582,8 +2582,8 @@ XLogFileCopy(XLogSegNo destsegno, TimeLineID srcTLI, XLogSegNo srcsegno)
25822582
* This is used both to install a newly-created segment (which has a temp
25832583
* filename while it's being created) and to recycle an old segment.
25842584
*
2585-
* *log, *seg: identify segment to install as (or first possible target).
2586-
* When find_free is TRUE,these are modified on return to indicate the
2585+
* *segno: identify segment to install as (or first possible target).
2586+
* When find_free is TRUE,this is modified on return to indicate the
25872587
* actual installation location or last segment searched.
25882588
*
25892589
* tmppath: initial name of file to install. It will be renamed into place.
@@ -3317,7 +3317,7 @@ PreallocXlogFiles(XLogRecPtr endptr)
33173317
}
33183318

33193319
/*
3320-
* Get thelog/seg of the latest removed or recycled WAL segment.
3320+
* Get thesegno of the latest removed or recycled WAL segment.
33213321
* Returns 0/0 if no WAL segments have been removed since startup.
33223322
*/
33233323
void
@@ -3332,7 +3332,7 @@ XLogGetLastRemoved(XLogSegNo *segno)
33323332
}
33333333

33343334
/*
3335-
* Update the last removedlog/seg pointer in shared memory, to reflect
3335+
* Update the last removedsegno pointer in shared memory, to reflect
33363336
* that the given XLOG file has been removed.
33373337
*/
33383338
staticvoid
@@ -3352,7 +3352,7 @@ UpdateLastRemovedPtr(char *filename)
33523352
}
33533353

33543354
/*
3355-
* Recycle or remove all log files older or equal to passedlog/seg#
3355+
* Recycle or remove all log files older or equal to passedsegno
33563356
*
33573357
* endptr is current (or recent) end of xlog; this is used to determine
33583358
* whether we want to recycle rather than delete no-longer-wanted log files.

‎src/backend/replication/walreceiver.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ walrcv_disconnect_type walrcv_disconnect = NULL;
6868
#defineNAPTIME_PER_CYCLE 100/* max sleep time between cycles (100ms) */
6969

7070
/*
71-
* These variables are used similarly to openLogFile/Id/Seg/Off,
71+
* These variables are used similarly to openLogFile/SegNo/Off,
7272
* but for walreceiver to write the XLOG. recvFileTLI is the TimeLineID
7373
* corresponding the filename of recvFile, used for error messages.
7474
*/

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp