NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitea56b06

committed

Fix wrong keysize in PrivateRefCountHash creation.

In4b4b680 I accidentally used sizeof(PrivateRefCountArray) instead ofsizeof(PrivateRefCountEntry) when creating the refcount overflowhashtable. As the former is bigger than the latter, this luckily onlyresulted in a slightly increased memory usage when many buffers arepinned in a backend.Reported-By: Takashi HorikawaDiscussion: 73FA3881462C614096F815F75628AFCD035A48C3@BPXM01GP.gisp.nec.co.jpBackpatch: 9.5, where thew new ref count infrastructure was introduced

1 parent64a169d commitea56b06Copy full SHA for ea56b06

File tree

1 file changed

-1

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-1

lines changed

`‎src/backend/storage/buffer/bufmgr.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2166,7 +2166,7 @@ InitBufferPoolAccess(void)`
`2166`	`2166`
`2167`	`2167`	`MemSet(&hash_ctl,0,sizeof(hash_ctl));`
`2168`	`2168`	`hash_ctl.keysize=sizeof(int32);`
`2169`		`-hash_ctl.entrysize=sizeof(PrivateRefCountArray);`
	`2169`	`+hash_ctl.entrysize=sizeof(PrivateRefCountEntry);`
`2170`	`2170`
`2171`	`2171`	`PrivateRefCountHash=hash_create("PrivateRefCount",100,&hash_ctl,`
`2172`	`2172`	`HASH_ELEM \|HASH_BLOBS);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitea56b06

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c`

0 commit comments