Commitea066f8

committed

Document that "Q" is ignored by to_date and to_timestamp. Add C comment

about the behavior.Document that quotes in to_date, to_timestamp, to_number skip inputcharacters.

1 parent61d7511 commitea066f8Copy full SHA for ea066f8

File tree

+12

-7

lines changed

+12

-7

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.506 2010/02/23 16:14:25 momjian Exp $ -->`
	`1`	`+<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.507 2010/03/03 22:28:42 momjian Exp $ -->`
`2`	`2`
`3`	`3`	`<chapter id="functions">`
`4`	`4`	`<title>Functions and Operators</title>`
`@@ -5089,7 +5089,7 @@ SELECT SUBSTRING('XY1234Z', 'Y*?([0-9]{1,3})');`
`5089`	`5089`	`</row>`
`5090`	`5090`	`<row>`
`5091`	`5091`	`<entry><literal>Q</literal></entry>`
`5092`		`- <entry>quarter</entry>`
	`5092`	`+ <entry>quarter (ignored by <function>to_date</> and <function>to_timestamp</>)</entry>`
`5093`	`5093`	`</row>`
`5094`	`5094`	`<row>`
`5095`	`5095`	`<entry><literal>RM</literal></entry>`
`@@ -5209,7 +5209,10 @@ SELECT SUBSTRING('XY1234Z', 'Y*?([0-9]{1,3})');`
`5209`	`5209`	`even if it contains pattern key words. For example, in`
`5210`	`5210`	`<literal>'"Hello Year "YYYY'</literal>, the <literal>YYYY</literal>`
`5211`	`5211`	`will be replaced by the year data, but the single <literal>Y</literal> in <literal>Year</literal>`
`5212`		`- will not be.`
	`5212`	`+ will not be. In <function>to_date</>, <function>to_number</>,`
	`5213`	`+ and <function>to_timestamp</>, double-quoted strings skip the number of`
	`5214`	`+ input characters contained in the string, e.g. <literal>"XX"</>`
	`5215`	`+ skips two input characters.`
`5213`	`5216`	`</para>`
`5214`	`5217`	`</listitem>`
`5215`	`5218`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.168 2010/02/26 02:01:08 momjian Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.169 2010/03/03 22:28:42 momjian Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2010, PostgreSQL Global Development Group`
`@@ -2671,10 +2671,12 @@ DCH_from_char(FormatNode node, char in, TmFromChar *out)`
`2671`	`2671`	`s+=SKIP_THth(n->suffix);`
`2672`	`2672`	`break;`
`2673`	`2673`	`caseDCH_Q:`
`2674`		`-`
`2675`	`2674`	`/*`
`2676`		`- * We ignore Q when converting to date because it is not`
`2677`		`- * normative.`
	`2675`	`+ * We ignore 'Q' when converting to date because it is`
	`2676`	`+ * unclear which date in the quarter to use, and some`
	`2677`	`+ * people specify both quarter and month, so if it was`
	`2678`	`+ * honored it might conflict with the supplied month.`
	`2679`	`+ * That is also why we don't throw an error.`
`2678`	`2680`	`*`
`2679`	`2681`	`* We still parse the source string for an integer, but it`
`2680`	`2682`	`* isn't stored anywhere in 'out'.`

Comments

(0)