NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commite952ae1

committed

Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark

the wrong buffer dirty when trying to kill a dead index entry that's ona page after the one it started on. No risk of data corruption, justinefficiency, but still a bug.

1 parentfa72121 commite952ae1Copy full SHA for e952ae1

File tree

1 file changed

-2

lines changed

src/backend/access/nbtree
- nbtinsert.c

1 file changed

-2

lines changed

`‎src/backend/access/nbtree/nbtinsert.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.125 2005/09/24 22:54:35 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.126 2005/10/12 17:18:03 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -261,7 +261,10 @@ _bt_check_unique(Relation rel, BTItem btitem, Relation heapRel,`
`261`	`261`	`hbuffer)==HEAPTUPLE_DEAD)`
`262`	`262`	`{`
`263`	`263`	`curitemid->lp_flags \|=LP_DELETE;`
`264`		`-SetBufferCommitInfoNeedsSave(buf);`
	`264`	`+if (nbuf!=InvalidBuffer)`
	`265`	`+SetBufferCommitInfoNeedsSave(nbuf);`
	`266`	`+else`
	`267`	`+SetBufferCommitInfoNeedsSave(buf);`
`265`	`268`	`}`
`266`	`269`	`LockBuffer(hbuffer,BUFFER_LOCK_UNLOCK);`
`267`	`270`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite952ae1

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtinsert.c`

0 commit comments