NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commite93c0b8

committed

After PageSetAllVisible, use MarkBufferDirty.

Previously, we used SetBufferCommitInfoNeedsSave, but that's reallyintended for dirty-marks we can theoretically afford to lose, such ashint bits. As for 9.2, the PD_ALL_VISIBLE mustn't be lost in thisway, since we could then end up with a heap page that isn'tall-visible and a visibility map page that is all visible, causingindex-only scans to return wrong answers.

1 parentb5eccae commite93c0b8Copy full SHA for e93c0b8

File tree

1 file changed

-2

lines changed

src/backend/commands
- vacuumlazy.c

1 file changed

-2

lines changed

`‎src/backend/commands/vacuumlazy.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,`
`603`	`603`	`if (!PageIsAllVisible(page))`
`604`	`604`	`{`
`605`	`605`	`PageSetAllVisible(page);`
`606`		`-SetBufferCommitInfoNeedsSave(buf);`
	`606`	`+MarkBufferDirty(buf);`
`607`	`607`	`}`
`608`	`608`
`609`	`609`	`LockBuffer(buf,BUFFER_LOCK_UNLOCK);`
`@@ -838,7 +838,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,`
`838`	`838`	`if (!PageIsAllVisible(page)&&all_visible)`
`839`	`839`	`{`
`840`	`840`	`PageSetAllVisible(page);`
`841`		`-SetBufferCommitInfoNeedsSave(buf);`
	`841`	`+MarkBufferDirty(buf);`
`842`	`842`	`}`
`843`	`843`
`844`	`844`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite93c0b8

File tree

1 file changed

1 file changed

`‎src/backend/commands/vacuumlazy.c‎`

0 commit comments