Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite7293e3

Browse files
committed
Work around an apparent bug in the Msys DTK perl's regex engine.
Several versions of the perl that comes with the Msys DTK have beenfound to have a bug that fails to recognize a ' before a multiline $ insome circumstances. To work around the problem, use a character classfor the '. Another solution would have been to use \n instead of $, butthat would have changed the test semantics very slightly.
1 parent6a1e14c commite7293e3

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

‎src/bin/pg_basebackup/t/010_pg_basebackup.pl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,9 @@
153153
'pg_basebackup -R runs');
154154
ok(-f"$tempdir/backupR/recovery.conf",'recovery.conf was created');
155155
my$recovery_conf = slurp_file"$tempdir/backupR/recovery.conf";
156-
like($recovery_conf,qr/^standby_mode = 'on'$/m,'recovery.conf sets standby_mode');
156+
# using a character class for the final "'" here works around an apparent
157+
# bug in several version of the Msys DTK perl
158+
like($recovery_conf,qr/^standby_mode = 'on[']$/m,'recovery.conf sets standby_mode');
157159
like($recovery_conf,qr/^primary_conninfo = '.*port=$ENV{PGPORT}.*'$/m,'recovery.conf sets primary_conninfo');
158160

159161
command_ok(['pg_basebackup','-D',"$tempdir/backupxf",'-X','fetch' ],

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp