Commite587e2e

committed

Make the comments more clear on the fact that UpdateFullPageWrites() is not

safe to call concurrently from multiple processes.

1 parent7714c63 commite587e2eCopy full SHA for e587e2e

File tree

-3

lines changed

-3

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8442,6 +8442,9 @@ XLogReportParameters(void)`
`8442`	`8442`	`/*`
`8443`	`8443`	`* Update full_page_writes in shared memory, and write an`
`8444`	`8444`	`* XLOG_FPW_CHANGE record if necessary.`
	`8445`	`+ *`
	`8446`	`+ * Note: this function assumes there is no other process running`
	`8447`	`+ * concurrently that could update it.`
`8445`	`8448`	`*/`
`8446`	`8449`	`void`
`8447`	`8450`	`UpdateFullPageWrites(void)`
`@@ -8452,8 +8455,8 @@ UpdateFullPageWrites(void)`
`8452`	`8455`	`* Do nothing if full_page_writes has not been changed.`
`8453`	`8456`	`*`
`8454`	`8457`	`* It's safe to check the shared full_page_writes without the lock,`
`8455`		`- * because wecan guaranteethat there is no concurrently running`
`8456`		`- *processwhich can update it.`
	`8458`	`+ * because weassumethat there is no concurrently running process`
	`8459`	`+ * which can update it.`
`8457`	`8460`	`*/`
`8458`	`8461`	`if (fullPageWrites==Insert->fullPageWrites)`
`8459`	`8462`	`return;`
`@@ -8490,7 +8493,6 @@ UpdateFullPageWrites(void)`
`8490`	`8493`	`XLogInsert(RM_XLOG_ID,XLOG_FPW_CHANGE,&rdata);`
`8491`	`8494`	`}`
`8492`	`8495`
`8493`		`-`
`8494`	`8496`	`if (!fullPageWrites)`
`8495`	`8497`	`{`
`8496`	`8498`	`LWLockAcquire(WALInsertLock,LW_EXCLUSIVE);`

Comments

(0)