NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commite2ce9aa

committed

Never crash-and-restart for bgworkers without shared memory access.

The motivation for a crash and restart cycle when a backend dies isthat it might have corrupted shared memory on the way down; and wecan't recover reliably except by reinitializing everything. But thatdoesn't apply to processes that don't touch shared memory. Currently,there's nothing to prevent a background worker that doesn't requestshared memory access from touching shared memory anyway, but that's aseparate bug.Previous to this commit, the coding in postmaster.c was inconsistent:an exit status other than 0 or 1 didn't provoke a crash-and-restart,but failure to release the postmaster child slot did. This changemakes those cases consistent.

1 parent1891b41 commite2ce9aaCopy full SHA for e2ce9aa

File tree

1 file changed

+10

-10

lines changed

src/backend/postmaster
- postmaster.c

1 file changed

+10

-10

lines changed

`‎src/backend/postmaster/postmaster.c‎`

Lines changed: 10 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -2864,17 +2864,17 @@ CleanupBackgroundWorker(int pid,`
`2864`	`2864`	`HandleChildCrash(pid,exitstatus,namebuf);`
`2865`	`2865`	`return true;`
`2866`	`2866`	`}`
`2867`		`-}`
`2868`	`2867`
`2869`		`-if (!ReleasePostmasterChildSlot(rw->rw_child_slot))`
`2870`		`-{`
`2871`		`-/*`
`2872`		`- * Uh-oh, the child failed to clean itself up. Treat as a crash`
`2873`		`- * after all.`
`2874`		`- */`
`2875`		`-rw->rw_crashed_at=GetCurrentTimestamp();`
`2876`		`-HandleChildCrash(pid,exitstatus,namebuf);`
`2877`		`-return true;`
	`2868`	`+if (!ReleasePostmasterChildSlot(rw->rw_child_slot))`
	`2869`	`+{`
	`2870`	`+/*`
	`2871`	`+ * Uh-oh, the child failed to clean itself up. Treat as a`
	`2872`	`+ * crash after all.`
	`2873`	`+ */`
	`2874`	`+rw->rw_crashed_at=GetCurrentTimestamp();`
	`2875`	`+HandleChildCrash(pid,exitstatus,namebuf);`
	`2876`	`+return true;`
	`2877`	`+}`
`2878`	`2878`	`}`
`2879`	`2879`
`2880`	`2880`	`/* Get it out of the BackendList and clear out remaining data */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite2ce9aa

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/postmaster.c‎`

0 commit comments